You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2023/12/28 09:08:26 UTC
[PR] chore: Fix RecipeAdhocSource test. [incubator-pekko]
He-Pin opened a new pull request, #888:
URL: https://github.com/apache/incubator-pekko/pull/888
refs: https://github.com/apache/incubator-pekko/issues/886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Fix RecipeAdhocSource test. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #888:
URL: https://github.com/apache/incubator-pekko/pull/888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Fix RecipeAdhocSource test. [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #888:
URL: https://github.com/apache/incubator-pekko/pull/888#discussion_r1437497649
##########
docs/src/test/scala/docs/stream/cookbook/RecipeAdhocSource.scala:
##########
@@ -13,12 +13,14 @@
package docs.stream.cookbook
-import java.util.concurrent.atomic.{ AtomicBoolean, AtomicInteger }
-import org.apache.pekko.stream.scaladsl.Source
-import org.apache.pekko.stream.testkit.scaladsl.TestSink
-import org.apache.pekko.testkit.TimingTest
-import org.apache.pekko.{ Done, NotUsed }
+import java.util.concurrent.atomic.{AtomicBoolean, AtomicInteger}
+import org.apache.pekko
+import pekko.stream.scaladsl.Source
+import pekko.stream.testkit.scaladsl.TestSink
+import pekko.stream.BackpressureTimeoutException
+import pekko.testkit.TimingTest
+import pekko.{Done, NotUsed}
Review Comment:
looks like a scalafrmt issue will happen - should be `pekko.{ Done, NotUsed }` - also line 17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Fix RecipeAdhocSource test. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #888:
URL: https://github.com/apache/incubator-pekko/pull/888#discussion_r1437528065
##########
docs/src/test/scala/docs/stream/cookbook/RecipeAdhocSource.scala:
##########
@@ -14,11 +14,12 @@
package docs.stream.cookbook
import java.util.concurrent.atomic.{ AtomicBoolean, AtomicInteger }
-
Review Comment:
That's right. I can do that later with a sortImports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Fix RecipeAdhocSource test. [incubator-pekko]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #888:
URL: https://github.com/apache/incubator-pekko/pull/888#issuecomment-1870985472
lgtm if ci passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Fix RecipeAdhocSource test. [incubator-pekko]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on code in PR #888:
URL: https://github.com/apache/incubator-pekko/pull/888#discussion_r1437510402
##########
docs/src/test/scala/docs/stream/cookbook/RecipeAdhocSource.scala:
##########
@@ -14,11 +14,12 @@
package docs.stream.cookbook
import java.util.concurrent.atomic.{ AtomicBoolean, AtomicInteger }
-
Review Comment:
Since you have modified the import here, I think keep black line to separate `org. apache. pekko` and `java. util`
besides I think the dependencies of pekko should be on the top part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org