You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Eelco Hillenius (JIRA)" <ji...@apache.org> on 2007/05/01 15:02:15 UTC
[jira] Created: (WICKET-519) remove page versions from the second
level cache when explicitly removed
remove page versions from the second level cache when explicitly removed
------------------------------------------------------------------------
Key: WICKET-519
URL: https://issues.apache.org/jira/browse/WICKET-519
Project: Wicket
Issue Type: Bug
Components: wicket
Reporter: Eelco Hillenius
Assigned To: Johan Compagner
Fix For: 1.3
Someone at Matej's session had an interesting question about how pages can be removed from the history when you explictly want to avoid users being able to go back to that version (i.e. expire them). Removing the page from the page map works fine with the HttpSessionStore, but doesn't with SecondLevelCacheSessionStore by the looks of it; FilePageStore#removePage just removes from pending but once it is serialized to disk, it will always be availalbe. I think this is wrong. An explicit call to PageMap#remove(Page) should remove it from second level cache so that it is in effect expired.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-519) remove page versions from the second
level cache when explicitly removed
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495311 ]
Eelco Hillenius commented on WICKET-519:
----------------------------------------
Just makes sense API wise though.
> remove page versions from the second level cache when explicitly removed
> ------------------------------------------------------------------------
>
> Key: WICKET-519
> URL: https://issues.apache.org/jira/browse/WICKET-519
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Eelco Hillenius
> Assigned To: Johan Compagner
> Fix For: 1.3
>
>
> Someone at Matej's session had an interesting question about how pages can be removed from the history when you explictly want to avoid users being able to go back to that version (i.e. expire them). Removing the page from the page map works fine with the HttpSessionStore, but doesn't with SecondLevelCacheSessionStore by the looks of it; FilePageStore#removePage just removes from pending but once it is serialized to disk, it will always be availalbe. I think this is wrong. An explicit call to PageMap#remove(Page) should remove it from second level cache so that it is in effect expired.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-519) remove page versions from the second
level cache when explicitly removed
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner closed WICKET-519.
----------------------------------
Resolution: Fixed
Pages are now removed from disk also (if you do PageMap.clear/remove then all the pages or Pagemap.remove(Page) then only that page.
> remove page versions from the second level cache when explicitly removed
> ------------------------------------------------------------------------
>
> Key: WICKET-519
> URL: https://issues.apache.org/jira/browse/WICKET-519
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: trunk
> Reporter: Eelco Hillenius
> Assignee: Johan Compagner
> Fix For: 1.3.0-rc1
>
>
> Someone at Matej's session had an interesting question about how pages can be removed from the history when you explictly want to avoid users being able to go back to that version (i.e. expire them). Removing the page from the page map works fine with the HttpSessionStore, but doesn't with SecondLevelCacheSessionStore by the looks of it; FilePageStore#removePage just removes from pending but once it is serialized to disk, it will always be availalbe. I think this is wrong. An explicit call to PageMap#remove(Page) should remove it from second level cache so that it is in effect expired.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-519) remove page versions from the second
level cache when explicitly removed
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495265 ]
Matej Knopp commented on WICKET-519:
------------------------------------
Sure we can do that. But thinking of it, there are so many simple ways of making the page no longer available in wicket (e.g add a obsolete flag and check it in onatach)...
> remove page versions from the second level cache when explicitly removed
> ------------------------------------------------------------------------
>
> Key: WICKET-519
> URL: https://issues.apache.org/jira/browse/WICKET-519
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Eelco Hillenius
> Assigned To: Johan Compagner
> Fix For: 1.3
>
>
> Someone at Matej's session had an interesting question about how pages can be removed from the history when you explictly want to avoid users being able to go back to that version (i.e. expire them). Removing the page from the page map works fine with the HttpSessionStore, but doesn't with SecondLevelCacheSessionStore by the looks of it; FilePageStore#removePage just removes from pending but once it is serialized to disk, it will always be availalbe. I think this is wrong. An explicit call to PageMap#remove(Page) should remove it from second level cache so that it is in effect expired.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-519) remove page versions from the second
level cache when explicitly removed
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-519:
--------------------------------
Fix Version/s: (was: trunk)
1.3.0-rc1
Affects Version/s: trunk
> remove page versions from the second level cache when explicitly removed
> ------------------------------------------------------------------------
>
> Key: WICKET-519
> URL: https://issues.apache.org/jira/browse/WICKET-519
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: trunk
> Reporter: Eelco Hillenius
> Assigned To: Johan Compagner
> Fix For: 1.3.0-rc1
>
>
> Someone at Matej's session had an interesting question about how pages can be removed from the history when you explictly want to avoid users being able to go back to that version (i.e. expire them). Removing the page from the page map works fine with the HttpSessionStore, but doesn't with SecondLevelCacheSessionStore by the looks of it; FilePageStore#removePage just removes from pending but once it is serialized to disk, it will always be availalbe. I think this is wrong. An explicit call to PageMap#remove(Page) should remove it from second level cache so that it is in effect expired.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.