Re: [PR] FINERACT-2432: LoanProductDataValidator.validateLoanScheduleType() throws NullPointerException when loanScheduleType is null [fineract]

["adamsaghy (via GitHub)" <gi...@apache.org>]

adamsaghy commented on code in PR #5288:
URL: https://github.com/apache/fineract/pull/5288#discussion_r2674010444


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/serialization/LoanProductDataValidator.java:
##########
@@ -2797,6 +2797,9 @@ public void fixedLengthValidations(final String transactionProcessingStrategyCod
     private void validateLoanScheduleType(final String transactionProcessingStrategyCode, final DataValidatorBuilder baseDataValidator,
             final JsonElement element) {
         final String loanScheduleType = this.fromApiJsonHelper.extractStringNamed(LoanProductConstants.LOAN_SCHEDULE_TYPE, element);
+        if (loanScheduleType == null) {

Review Comment:
   Having `null` value is not correct and it shall fail the validation and throw error!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org