You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/14 02:18:40 UTC
[GitHub] [shardingsphere] LeeGuoPing opened a new pull request, #19123: Refactor SQLParserTestCases#getAllSQLParserTestCases
LeeGuoPing opened a new pull request, #19123:
URL: https://github.com/apache/shardingsphere/pull/19123
Changes proposed in this pull request:
background:
`SQLParserTestCases ` # `getAllSQLParserTestCases `method is becoming longer and longer. Each time add a new test case, add test case as a global variable of `SQLParserTestCases `, and also add it into the `getAllSQLParserTestCases` method.
n addition, every time the list is empty, a temporary useless map will be created
-
-
-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #19123: Refactor SQLParserTestCases#getAllSQLParserTestCases
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19123:
URL: https://github.com/apache/shardingsphere/pull/19123#issuecomment-1183928609
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19123?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19123](https://codecov.io/gh/apache/shardingsphere/pull/19123?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (938bf2a) into [master](https://codecov.io/gh/apache/shardingsphere/commit/965224497dcb647b1937a5cb4350db63bd8893e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9652244) will **decrease** coverage by `0.28%`.
> The diff coverage is `83.33%`.
```diff
@@ Coverage Diff @@
## master #19123 +/- ##
============================================
- Coverage 59.45% 59.17% -0.29%
- Complexity 2325 2330 +5
============================================
Files 3803 3803
Lines 54662 54293 -369
Branches 9217 9221 +4
============================================
- Hits 32500 32126 -374
- Misses 19443 19446 +3
- Partials 2719 2721 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/19123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...eterized/jaxb/cases/domain/SQLParserTestCases.java](https://codecov.io/gh/apache/shardingsphere/pull/19123/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvamF4Yi9jYXNlcy9kb21haW4vU1FMUGFyc2VyVGVzdENhc2VzLmphdmE=) | `99.27% <83.33%> (-0.61%)` | :arrow_down: |
| [...engauss/ingest/wal/decode/MppdbDecodingPlugin.java](https://codecov.io/gh/apache/shardingsphere/pull/19123/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1kaWFsZWN0L3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUtb3BlbmdhdXNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL29wZW5nYXVzcy9pbmdlc3Qvd2FsL2RlY29kZS9NcHBkYkRlY29kaW5nUGx1Z2luLmphdmE=) | `73.87% <0.00%> (-1.36%)` | :arrow_down: |
| [...ine/scenario/rulealtered/RuleAlteredJobCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/19123/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL3NjZW5hcmlvL3J1bGVhbHRlcmVkL1J1bGVBbHRlcmVkSm9iQ2VudGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19123?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19123?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9652244...938bf2a](https://codecov.io/gh/apache/shardingsphere/pull/19123?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] LeeGuoPing commented on pull request #19123: Refactor SQLParserTestCases#getAllSQLParserTestCases
Posted by GitBox <gi...@apache.org>.
LeeGuoPing commented on PR #19123:
URL: https://github.com/apache/shardingsphere/pull/19123#issuecomment-1185193483
> Please resolve conflict
@terrymanu done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #19123: Refactor SQLParserTestCases#getAllSQLParserTestCases
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #19123:
URL: https://github.com/apache/shardingsphere/pull/19123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org