You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "ArnavBalyan (via GitHub)" <gi...@apache.org> on 2025/04/23 16:37:56 UTC
[PR] [GLUTEN][VL] Enable RAS for CI Spark 3.3 [incubator-gluten]
ArnavBalyan opened a new pull request, #9405:
URL: https://github.com/apache/incubator-gluten/pull/9405
## What changes were proposed in this pull request?
- RAS enabled is only running for Spark 3.5
- Certain failed tests were previously only seen with RAS enabled.
- Enabling it, since Spark 33 is has significant changes from 3.5 and users can introduce changes for lower versions.
- Only enabling for 33 for now to save resources
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN][VL] Enable RAS for CI Spark 3.3 [incubator-gluten]
Posted by "ArnavBalyan (via GitHub)" <gi...@apache.org>.
ArnavBalyan commented on PR #9405:
URL: https://github.com/apache/incubator-gluten/pull/9405#issuecomment-2826384442
> @ArnavBalyan
>
> > was not sure if there was some reason to enable only for 3.5,
>
> It was for saving CI resources. So we just covered the latest version.
>
> If there aren't other specific reasons, I think it's fine to keep it in 3.5 for now. Given the optimizer code is 99% similar among different Spark versions. We can tolerate a little coverage loss to save some Ci resource.
Yes makes sense, interestingly there is a failure in spark 33 RAS test. I'll take a look and try to fix, makes me think if it would be good to have it. Let me close this for now, can revisit in future if needed? @zhztheplayer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN][VL] Enable RAS for CI Spark 3.3 [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on PR #9405:
URL: https://github.com/apache/incubator-gluten/pull/9405#issuecomment-2824951534
@ArnavBalyan
> was not sure if there was some reason to enable only for 3.5,
It was for saving CI resources. So we just covered the latest version.
If there aren't other specific reasons, I think it's fine to keep it in 3.5 for now. Given the optimizer code is 99% similar among different Spark versions. We can tolerate a little coverage loss to save some Ci resource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN][VL] Enable RAS for CI Spark 3.3 [incubator-gluten]
Posted by "ArnavBalyan (via GitHub)" <gi...@apache.org>.
ArnavBalyan commented on PR #9405:
URL: https://github.com/apache/incubator-gluten/pull/9405#issuecomment-2827090411
> > Let me close this for now, can revisit in future if needed? @zhztheplayer
>
> Yes, thanks!
>
> If you have local test failures, perhaps add a local UT with RAS=ON to cover that specific case :)
Got it thanks! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN][VL] Enable RAS for CI Spark 3.3 [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on PR #9405:
URL: https://github.com/apache/incubator-gluten/pull/9405#issuecomment-2826981748
> Let me close this for now, can revisit in future if needed? @zhztheplayer
Yes, thanks!
If you have local test failures, perhaps add a local UT with RAS=ON to cover that specific case :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN][VL] Enable RAS for CI Spark 3.3 [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9405:
URL: https://github.com/apache/incubator-gluten/pull/9405#issuecomment-2824898073
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICEGJ-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename ***commit message*** and ***pull request title*** in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
* [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN][VL] Enable RAS for CI Spark 3.3 [incubator-gluten]
Posted by "ArnavBalyan (via GitHub)" <gi...@apache.org>.
ArnavBalyan commented on PR #9405:
URL: https://github.com/apache/incubator-gluten/pull/9405#issuecomment-2824903560
cc @zhztheplayer, was not sure if there was some reason to enable only for 3.5, please let me know incase this is not needed. Just thought would help improve coverage against such issues https://github.com/apache/incubator-gluten/pull/9145 thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN][VL] Enable RAS for CI Spark 3.3 [incubator-gluten]
Posted by "ArnavBalyan (via GitHub)" <gi...@apache.org>.
ArnavBalyan closed pull request #9405: [GLUTEN][VL] Enable RAS for CI Spark 3.3
URL: https://github.com/apache/incubator-gluten/pull/9405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org