[GitHub] [spark] srowen commented on a change in pull request #34760: [SPARK-37506][CORE][SQL][DSTREAM][GRAPHX][ML][MLLIB][SS][EXAMPLES] Change the never changed 'var' to 'val'

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #34760:
URL: https://github.com/apache/spark/pull/34760#discussion_r762443083



##########
File path: core/src/main/scala/org/apache/spark/status/LiveEntity.scala
##########
@@ -908,7 +908,7 @@ private[spark] class LiveMiscellaneousProcess(val processId: String,
   var isActive = true
   var totalCores = 0
   val addTime = new Date(creationTime)
-  var removeTime: Date = null
+  val removeTime: Date = null

Review comment:
       It'd be weird if this were always null and never changed. Indeed it looks like this is modified in AppStatusListener?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org