You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/10/22 23:52:56 UTC

[GitHub] zhreshold commented on a change in pull request #12912: Add bytearray support back to imdecode (#12855, #12868)

zhreshold commented on a change in pull request #12912: Add bytearray support back to imdecode (#12855, #12868)
URL: https://github.com/apache/incubator-mxnet/pull/12912#discussion_r227176856
 
 

 ##########
 File path: tests/python/unittest/test_image.py
 ##########
 @@ -92,6 +94,26 @@ def test_imdecode(self):
             cv_image = cv2.imread(img)
             assert_almost_equal(image.asnumpy(), cv_image)
 
+    def test_imdecode_bytearray(self):
 
 Review comment:
   I think the tests should target exception handling. 
   Can you please also add a test that assertRaises if the buf is empty?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services