[GitHub] [superset] michael-s-molina commented on a diff in pull request #19493: chore: Removes hard-coded colors from legacy-plugin-chart-sankey

[GitBox <gi...@apache.org>]

michael-s-molina commented on code in PR #19493:
URL: https://github.com/apache/superset/pull/19493#discussion_r841947048


##########
superset-frontend/plugins/legacy-plugin-chart-sankey/src/ReactSankey.jsx:
##########
@@ -34,40 +34,42 @@ SankeyComponent.propTypes = {
 };
 
 export default styled(SankeyComponent)`
-  .superset-legacy-chart-sankey {
-    .node {
-      rect {
-        cursor: move;
-        fill-opacity: 0.9;
-        shape-rendering: crispEdges;
+  ${({ theme }) => `
+    .superset-legacy-chart-sankey {
+      .node {
+        rect {
+          cursor: move;
+          fill-opacity: 0.9;

Review Comment:
   Nice catch! Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org