You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/02/17 10:27:32 UTC
[GitHub] [incubator-iotdb] liutaohua commented on a change in pull request
#818: [IOTDB-482] Vectorized TimeGenerator
liutaohua commented on a change in pull request #818: [IOTDB-482] Vectorized TimeGenerator
URL: https://github.com/apache/incubator-iotdb/pull/818#discussion_r380099503
##########
File path: server/src/main/java/org/apache/iotdb/db/query/timegenerator/EngineTimeGenerator.java
##########
@@ -51,12 +54,17 @@ private void initNode(QueryContext context) throws StorageEngineException {
@Override
public boolean hasNext() throws IOException {
- return operatorNode.hasNext();
+ return (cacheTimes != null && cacheTimes.hasMoreData()) || operatorNode.hasNext();
}
@Override
public long next() throws IOException {
- return operatorNode.next();
+ if (cacheTimes == null || !cacheTimes.hasMoreData()) {
Review comment:
this return value was `long` not batch, but i'm impl with your suggestion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services