[GitHub] [spark] HyukjinKwon commented on a change in pull request #34901: [SPARK-37646][SQL]Avoid touching Scala reflection APIs in the lit function

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #34901:
URL: https://github.com/apache/spark/pull/34901#discussion_r769148811



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -134,6 +144,9 @@ object functions {
    * The difference between this function and [[lit]] is that this function
    * can handle parameterized scala types e.g.: List, Seq and Map.
    *
+   * Note: `typedlit` will call expensive Scala reflection APIs. `lit` is preferred if parameterized
+   * scala types are not used.

Review comment:
       ```suggestion
      * @note `typedlit` will call expensive Scala reflection APIs. `lit` is preferred if parameterized
      * Scala types are not used.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org