You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by wj...@apache.org on 2023/09/11 02:41:27 UTC
[arrow-datafusion] branch 6171-simplify-with-guarantee updated (a9aeecf02f -> 16d78c64d1)
This is an automated email from the ASF dual-hosted git repository.
wjones127 pushed a change to branch 6171-simplify-with-guarantee
in repository https://gitbox.apache.org/repos/asf/arrow-datafusion.git
omit a9aeecf02f fix test to be false or null, not true
new 16d78c64d1 fix test to be false or null, not true
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (a9aeecf02f)
\
N -- N -- N refs/heads/6171-simplify-with-guarantee (16d78c64d1)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
datafusion/physical-expr/src/intervals/interval_aritmetic.rs | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
[arrow-datafusion] 01/01: fix test to be false or null, not true
Posted by wj...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
wjones127 pushed a commit to branch 6171-simplify-with-guarantee
in repository https://gitbox.apache.org/repos/asf/arrow-datafusion.git
commit 16d78c64d15946ed59c40f92e609094c50cdd3d5
Author: Will Jones <wi...@gmail.com>
AuthorDate: Sun Sep 10 17:22:02 2023 -0700
fix test to be false or null, not true
---
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs | 4 ++--
datafusion/physical-expr/src/intervals/interval_aritmetic.rs | 8 ++++----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs b/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs
index edea3a7b95..9b3f710ea8 100644
--- a/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs
+++ b/datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs
@@ -3271,7 +3271,7 @@ mod tests {
let output = simplify_with_guarantee(expr.clone(), &guarantees);
assert_eq!(output, lit(false));
- // Guaranteed true or null -> no change.
+ // Guaranteed false or null -> no change.
let guarantees = vec![
(
col("c3"),
@@ -3283,7 +3283,7 @@ mod tests {
(
col("c4"),
NullableInterval {
- values: Interval::make(Some(0_u32), Some(5_u32), (false, false)),
+ values: Interval::make(Some(9_u32), Some(9_u32), (false, false)),
is_valid: Interval::UNCERTAIN,
},
),
diff --git a/datafusion/physical-expr/src/intervals/interval_aritmetic.rs b/datafusion/physical-expr/src/intervals/interval_aritmetic.rs
index 7dcf331751..caf15dac7d 100644
--- a/datafusion/physical-expr/src/intervals/interval_aritmetic.rs
+++ b/datafusion/physical-expr/src/intervals/interval_aritmetic.rs
@@ -743,19 +743,19 @@ enum NullStatus {
/// NullableInterval {
/// values: Interval::make(Some(1), Some(2), (false, true)),
/// is_valid: Interval::UNCERTAIN,
-/// }
+/// };
///
/// // (0, ∞)
/// NullableInterval {
/// values: Interval::make(Some(0), None, (true, true)),
/// is_valid: Interval::CERTAINLY_TRUE,
-/// }
+/// };
///
/// // {NULL}
-/// NullableInterval::from(ScalarValue::Int32(None))
+/// NullableInterval::from(&ScalarValue::Int32(None));
///
/// // {4}
-/// NullableInterval::from(ScalarValue::Int32(4))
+/// NullableInterval::from(&ScalarValue::Int32(Some(4)));
/// ```
#[derive(Debug, Clone, PartialEq, Eq, Default)]
pub struct NullableInterval {