[jira] [Resolved] (TS-2279) proxy.config.exec_thread.affinity's values

["Phil Sorber (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phil Sorber resolved TS-2279.
-----------------------------

    Resolution: Fixed

Separate from this ticket, I had reworked this code. That is why the docs differ between versions. The code quoted has all been reworked and the only part still broken here was the range (that is not enforced as far as I know) and is fixed now.

> proxy.config.exec_thread.affinity's values
> ------------------------------------------
>
>                 Key: TS-2279
>                 URL: https://issues.apache.org/jira/browse/TS-2279
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Configuration
>            Reporter: Igor Galić
>            Assignee: Phil Sorber
>             Fix For: 5.1.0
>
>
> The setting of {{proxy.config.exec_thread.affinity}} only has an affect when traffic server was compiled with {{\-\-enable-hwloc}}. It has *no* affect at all, not even a warning about its being ineffectual when setting that value while trafficserver is *not* configured with {{--enable-hwloc}}.
> Further, mgmt/RecordsConfig.cc defines a range of {{[0-1]}}:
> {code}
>  {RECT_CONFIG, "proxy.config.exec_thread.affinity", RECD_INT, "0", RECU_RESTART_TS, RR_NULL, RECC_INT, "[0-1]", RECA_READ_ONLY}
> {code}
> but the code uses a range of [0-3]:
> {code}
> #if TS_USE_HWLOC
>     if (affinity != 0) {
>       int logical_ratio;
>       switch(affinity) {
>       case 3:           // assign threads to logical cores
>         logical_ratio = 1;
>         break;
>       case 2:           // assign threads to real cores
>         logical_ratio = pu / cu;
>         break;
>       case 1:           // assign threads to sockets
>       default:
>         logical_ratio = pu / socket;
>       }
> {code}
> And finally, 1 is the default value, rather than issuing a warning about an incorrect value.



--
This message was sent by Atlassian JIRA
(v6.2#6252)