You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/08 19:18:24 UTC

[GitHub] srowen commented on issue #20793: [WIP][SPARK-23643] Shrinking the buffer in hashSeed up to size of the seed parameter

srowen commented on issue #20793: [WIP][SPARK-23643] Shrinking the buffer in hashSeed up to size of the seed parameter
URL: https://github.com/apache/spark/pull/20793#issuecomment-461914693
 
 
   The tests need to be deterministic, but you are correct that some tests go a little too far in asserting the exact result of the random sampling. If the result is still correct, it is reasonable to just update the new expected value. But it could be fine to loosen some tests too if they are overly specific without much value. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org