[jira] [Updated] (OFBIZ-1524) Improve the way CreditCard.cardType field is managed

["Akash Jain (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Akash Jain updated OFBIZ-1524:
------------------------------
    Attachment: OFBIZ-1524.patch

Done, attached patch for the same.

> Improve the way CreditCard.cardType field is managed
> ----------------------------------------------------
>
>                 Key: OFBIZ-1524
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1524
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting, order, specialpurpose/ecommerce
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: OFBIZ-1524.patch
>
>
> The credit card types are hardcoded in the following template (and in a few other ftl files):
> http://svn.apache.org/repos/asf/ofbiz/trunk/framework/common/webcommon/includes/cctypes.ftl
> instead getting the values from the Enumeration entity (we already have value for credit card types, with enumTypeId="CREDIT_CARD_TYPE")
> Also, in the CreditCard.cardType field, instead of storing the Enumeration.enumId field (e.g. CCT_VISA) we store the Enumeration.enumCode field (e.g. "Visa")
> This value is also used in some of the UtilValidate methods; it would be much better to use everywhere the values in the enumId entity.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)