You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Igal Sapir <is...@apache.org> on 2019/02/05 18:02:51 UTC
Test Case Ciphers (was: Release Apache Tomcat 8.5.38)
Emmanuel,
On 2/5/2019 6:27 AM, Emmanuel Bourg wrote:
> <snip/>
> Tested on Debian with OpenJDK 11.0.2, OpenSSL 1.1.1a and Tomcat Native
> 1.2.21. No failure on the 3 test suites.
Do you get any "missing ciphers" errors or not even that? I always get
some test cases fail due to mismatching ciphers, which I accept as false
positives, so I wonder about that.
Thanks,
Igal
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Test Case Ciphers (was: Release Apache Tomcat 8.5.38)
Posted by Igal Sapir <ig...@lucee.org>.
Emmanuel,
On Tue, Feb 5, 2019 at 11:45 AM Igal Sapir <ig...@lucee.org> wrote:
> On Tue, Feb 5, 2019 at 11:12 AM Emmanuel Bourg <eb...@apache.org> wrote:
>
>> Le 05/02/2019 à 19:02, Igal Sapir a écrit :
>>
>> > Do you get any "missing ciphers" errors or not even that? I always get
>> > some test cases fail due to mismatching ciphers, which I accept as false
>> > positives, so I wonder about that.
>>
>> Yes that's normal, some ciphers are disabled in Debian (IDEA and ARIA).
>> There is a patch adjusting the tests accordingly:
>>
>>
>> https://salsa.debian.org/java-team/tomcat8/blob/master/debian/patches/0021-dont-test-unsupported-ciphers.patch
>>
>> Emmanuel Bourg
>>
>
> I see. That makes sense, thanks.
>
> What do you guys think if I add a system property like
> `test.unimplementedciphers` with an empty default, which can be used, e.g.:
>
> test.unimplementedciphers=ARIA,IDEA
>
> Then any cipher that has in its name the substring ARIA or IDEA will be
> skipped?
>
Please see
https://github.com/apache/tomcat/commit/a9c1a0661198d9ba37c1facd8385fe05d538c4ad
based on your input.
Best,
Igal
Re: Test Case Ciphers (was: Release Apache Tomcat 8.5.38)
Posted by Igal Sapir <ig...@lucee.org>.
On Tue, Feb 5, 2019 at 11:12 AM Emmanuel Bourg <eb...@apache.org> wrote:
> Le 05/02/2019 à 19:02, Igal Sapir a écrit :
>
> > Do you get any "missing ciphers" errors or not even that? I always get
> > some test cases fail due to mismatching ciphers, which I accept as false
> > positives, so I wonder about that.
>
> Yes that's normal, some ciphers are disabled in Debian (IDEA and ARIA).
> There is a patch adjusting the tests accordingly:
>
>
> https://salsa.debian.org/java-team/tomcat8/blob/master/debian/patches/0021-dont-test-unsupported-ciphers.patch
>
> Emmanuel Bourg
>
I see. That makes sense, thanks.
What do you guys think if I add a system property like
`test.unimplementedciphers` with an empty default, which can be used, e.g.:
test.unimplementedciphers=ARIA,IDEA
Then any cipher that has in its name the substring ARIA or IDEA will be
skipped?
Igal
Re: Test Case Ciphers (was: Release Apache Tomcat 8.5.38)
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 05/02/2019 à 19:02, Igal Sapir a écrit :
> Do you get any "missing ciphers" errors or not even that? I always get
> some test cases fail due to mismatching ciphers, which I accept as false
> positives, so I wonder about that.
Yes that's normal, some ciphers are disabled in Debian (IDEA and ARIA).
There is a patch adjusting the tests accordingly:
https://salsa.debian.org/java-team/tomcat8/blob/master/debian/patches/0021-dont-test-unsupported-ciphers.patch
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: Test Case Ciphers (was: Release Apache Tomcat 8.5.38)
Posted by Igal Sapir <ig...@lucee.org>.
On Tue, Feb 5, 2019 at 10:02 AM Igal Sapir <is...@apache.org> wrote:
> Emmanuel,
>
> On 2/5/2019 6:27 AM, Emmanuel Bourg wrote:
>
> > <snip/>
> > Tested on Debian with OpenJDK 11.0.2, OpenSSL 1.1.1a and Tomcat Native
> > 1.2.21. No failure on the 3 test suites.
>
> Do you get any "missing ciphers" errors or not even that? I always get
> some test cases fail due to mismatching ciphers, which I accept as false
> positives, so I wonder about that.
>
Log entries of failed test cases can be seen at:
https://github.com/isapir/scrapbook/blob/master/tomcat-test-failed-ciphers-20190205.log
Igal