You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/05 22:41:59 UTC

[GitHub] [kafka] hachikuji commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

hachikuji commented on a change in pull request #9563:
URL: https://github.com/apache/kafka/pull/9563#discussion_r518414400



##########
File path: clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java
##########
@@ -89,10 +89,11 @@ public ResponseHeader toResponseHeader() {
     public static RequestHeader parse(ByteBuffer buffer) {
         short apiKey = -1;
         try {
+            int position = buffer.position();

Review comment:
       This was a bug. This logic assumes that the buffer is at position 0. Let me add a test case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org