You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/10/02 04:09:49 UTC

[GitHub] [maven] olamy commented on a change in pull request #558: [MNG-7272] - Code Improvement - II

olamy commented on a change in pull request #558:
URL: https://github.com/apache/maven/pull/558#discussion_r720622728



##########
File path: maven-core/src/main/java/org/apache/maven/graph/DefaultProjectDependencyGraph.java
##########
@@ -61,39 +61,25 @@
      * @throws DuplicateProjectException
      * @throws CycleDetectedException
      */
-    public DefaultProjectDependencyGraph( Collection<MavenProject> projects )
-        throws CycleDetectedException, DuplicateProjectException
+    public DefaultProjectDependencyGraph( final Collection<MavenProject> projects )

Review comment:
       > The original code has the same `final` for parameters: https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/graph/DefaultProjectDependencyGraph.java#L92 I just want to keep it the way...but I'm the same opinion to remove `final`..
   
   
   so remove it ;) 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org