You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2016/11/28 06:19:47 UTC
Review Request 54113: Added support for specifying how a socket
should be shutdown.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54113/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Added support for specifying how a socket should be shutdown.
Diffs
-----
3rdparty/libprocess/include/process/socket.hpp f798af7879546d71e8ef4a295c9cf489a70cb61f
Diff: https://reviews.apache.org/r/54113/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 54113: Added support for specifying how a socket
should be shutdown.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Nov. 28, 2016, 6:25 p.m., Greg Mann wrote:
> > 3rdparty/libprocess/include/process/socket.hpp, lines 394-396
> > <https://reviews.apache.org/r/54113/diff/1/?file=1570964#file1570964line394>
> >
> > BenM pointed out on my similar review that we need to alter our Windows headers to map the POSIX constants `SHUT_WR` and `SHUT_RDWR` onto their Windows equivalents. Something like this: https://reviews.apache.org/r/53990/
I'll commit your patch first, thanks Greg!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54113/#review157083
-----------------------------------------------------------
On Nov. 28, 2016, 6:19 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54113/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2016, 6:19 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added support for specifying how a socket should be shutdown.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp f798af7879546d71e8ef4a295c9cf489a70cb61f
>
> Diff: https://reviews.apache.org/r/54113/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 54113: Added support for specifying how a socket
should be shutdown.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54113/#review157083
-----------------------------------------------------------
3rdparty/libprocess/include/process/socket.hpp (lines 392 - 394)
<https://reviews.apache.org/r/54113/#comment227500>
BenM pointed out on my similar review that we need to alter our Windows headers to map the POSIX constants `SHUT_WR` and `SHUT_RDWR` onto their Windows equivalents. Something like this: https://reviews.apache.org/r/53990/
- Greg Mann
On Nov. 28, 2016, 6:19 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54113/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2016, 6:19 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added support for specifying how a socket should be shutdown.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp f798af7879546d71e8ef4a295c9cf489a70cb61f
>
> Diff: https://reviews.apache.org/r/54113/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 54113: Added support for specifying how a socket
should be shutdown.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54113/#review157188
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/include/process/socket.hpp (line 388)
<https://reviews.apache.org/r/54113/#comment227623>
Can you leave a TODO to avoid having READ as the default in favor of READ_WRITE? Alternatively, we could remove the default entirely.
3rdparty/libprocess/include/process/socket.hpp (line 390)
<https://reviews.apache.org/r/54113/#comment227625>
Do you want a reference capture?
3rdparty/libprocess/include/process/socket.hpp (lines 392 - 394)
<https://reviews.apache.org/r/54113/#comment227624>
Be sure to commit greg's windows fix for mapping SHUT_WR and SHUT_RDWR before you commit this.
- Benjamin Mahler
On Nov. 28, 2016, 6:19 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54113/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2016, 6:19 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added support for specifying how a socket should be shutdown.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp f798af7879546d71e8ef4a295c9cf489a70cb61f
>
> Diff: https://reviews.apache.org/r/54113/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 54113: Added support for specifying how a socket
should be shutdown.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54113/
-----------------------------------------------------------
(Updated Nov. 29, 2016, 8:24 p.m.)
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Added support for specifying how a socket should be shutdown.
Diffs (updated)
-----
3rdparty/libprocess/include/process/socket.hpp f798af7879546d71e8ef4a295c9cf489a70cb61f
Diff: https://reviews.apache.org/r/54113/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman