You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by ijuma <gi...@git.apache.org> on 2017/05/30 12:14:46 UTC
[GitHub] kafka pull request #3166: KAFKA-5316: Follow-up with ByteBufferOutputStream ...
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/3166
KAFKA-5316: Follow-up with ByteBufferOutputStream and other misc improvements
ByteBufferOutputStream improvements:
* Document pitfalls
* Improve efficiency when dealing with direct byte buffers
* Improve handling of buffer expansion
* Be consistent about using `limit` instead of `capacity
Other minor changes:
* Fix log warning to specify correct Kafka version
* Clean-ups
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka minor-kafka-5316-follow-ups
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3166.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3166
----
commit 4b7e253d8d83c77600fe513790a6871c90aef5e9
Author: Ismael Juma <is...@juma.me.uk>
Date: 2017-05-30T12:05:32Z
A few improvements to ByteBufferOutputStream
1. Document pitfalls
2. Improve efficiency when dealing with direct byte buffers
3. Improve handling of buffer expansion
4. Be consistent about using `limit` instead of `capacity`
commit bc398d86e2f48dab7e5275f51c122dbeb65094c0
Author: Ismael Juma <is...@juma.me.uk>
Date: 2017-05-30T12:06:09Z
Fix log warning to specify correct Kafka version
commit f62ad676d5eb827c78af40ade485528474217ea9
Author: Ismael Juma <is...@juma.me.uk>
Date: 2017-05-30T12:09:54Z
Remove a couple of cases where a ByteBuffer is passed to `ByteBufferOutputStream`
There are many more and some do it for good reasons, but these seemed easy to fix.
commit 35d15b6d39e02e1f290f3308237cbade19e39847
Author: Ismael Juma <is...@juma.me.uk>
Date: 2017-05-30T12:10:47Z
Remove a couple of redundant fields in `MemoryRecordsBuilder`
commit e661eda83bc609f02f968a2ffb48cd8d66c53a29
Author: Ismael Juma <is...@juma.me.uk>
Date: 2017-05-30T12:11:03Z
Minor grammar fix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka pull request #3166: KAFKA-5316: Follow-up with ByteBufferOutputStream ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/3166
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---