You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Philippe Mouawad <ph...@gmail.com> on 2016/03/11 21:10:23 UTC
Drop some properties and merge icon.properties with icons-toolbar.properties
Hello,
I suggest we drop the following:
- jmeter.toolbar.display
- jmeter.errorscounter.display
- jmeter.icons
Because:
1. Why would somebody not want the toolbar ?
2. Why would somebody not want the errors counter ?
3. Do we really need to provide customization of icons ? New ones are
nice, that's it
Shouldn't we also merge:
icons-toolbar.properties and icon.properties ?
We already have a lot of properties.
--
Cordialement.
Philippe Mouawad.
Re: Drop some properties and merge icon.properties with icons-toolbar.properties
Posted by Philippe Mouawad <ph...@gmail.com>.
Shall I drop it ?
I am ready to commit
On Fri, Mar 25, 2016 at 12:08 PM, Milamber <mi...@apache.org> wrote:
>
> What about the Options menu > Toolbar?
>
>
> On 25/03/2016 07:45, Philippe Mouawad wrote:
>
>> Hi,
>> Ok I will drop :
>> - jmeter.toolbar.display
>> - jmeter.errorscounter.display
>>
>> And leave this one but not exposed in jmeter.properties:
>> - jmeter.icons
>>
>> Regards
>>
>> On Thu, Mar 24, 2016 at 11:43 PM, sebb <se...@gmail.com> wrote:
>>
>> On 24 March 2016 at 21:20, Philippe Mouawad <ph...@gmail.com>
>>> wrote:
>>>
>>>> Hello,
>>>> I have asked on mailing list and the answers (3 only) I got all say
>>>> they
>>>> are not used.
>>>> Shall I drop them ?
>>>>
>>> I would prefer to keep jmeter.icons
>>> It's useful for trialling new sets.
>>>
>>> Regards
>>>>
>>>> On Sat, Mar 12, 2016 at 1:52 PM, Philippe Mouawad <
>>>> philippe.mouawad@gmail.com> wrote:
>>>>
>>>> I've sent a mail to users mailing list
>>>>>
>>>>> On Sat, Mar 12, 2016 at 1:44 PM, sebb <se...@gmail.com> wrote:
>>>>>
>>>>> On 11 March 2016 at 20:10, Philippe Mouawad <
>>>>>>
>>>>> philippe.mouawad@gmail.com>
>>>
>>>> wrote:
>>>>>>
>>>>>>> Hello,
>>>>>>> I suggest we drop the following:
>>>>>>>
>>>>>>> - jmeter.toolbar.display
>>>>>>> - jmeter.errorscounter.display
>>>>>>> - jmeter.icons
>>>>>>>
>>>>>>> Because:
>>>>>>>
>>>>>>> 1. Why would somebody not want the toolbar ?
>>>>>>>
>>>>>> Have you asked the users?
>>>>>>
>>>>>> 2. Why would somebody not want the errors counter ?
>>>>>>>
>>>>>> Ditto.
>>>>>>
>>>>>> 3. Do we really need to provide customization of icons ? New ones
>>>>>>>
>>>>>> are
>>>
>>>> nice, that's it
>>>>>>>
>>>>>> They may not suit all tastes or all types of eyesight; why drop the
>>>>>>
>>>>> code?
>>>
>>>> Shouldn't we also merge:
>>>>>>> icons-toolbar.properties and icon.properties ?
>>>>>>>
>>>>>>> We already have a lot of properties.
>>>>>>>
>>>>>>> --
>>>>>>> Cordialement.
>>>>>>> Philippe Mouawad.
>>>>>>>
>>>>>>
>>>>>
>>>>> --
>>>>> Cordialement.
>>>>> Philippe Mouawad.
>>>>>
>>>>>
>>>>>
>>>>>
>>>> --
>>>> Cordialement.
>>>> Philippe Mouawad.
>>>>
>>>
>>
>>
>
--
Cordialement.
Philippe Mouawad.
Re: Drop some properties and merge icon.properties with icons-toolbar.properties
Posted by Philippe Mouawad <ph...@gmail.com>.
I removed this part within commit :
http://svn.apache.org/viewvc?rev=1736812&view=rev
On Fri, Mar 25, 2016 at 12:08 PM, Milamber <mi...@apache.org> wrote:
>
> What about the Options menu > Toolbar?
>
>
> On 25/03/2016 07:45, Philippe Mouawad wrote:
>
>> Hi,
>> Ok I will drop :
>> - jmeter.toolbar.display
>> - jmeter.errorscounter.display
>>
>> And leave this one but not exposed in jmeter.properties:
>> - jmeter.icons
>>
>> Regards
>>
>> On Thu, Mar 24, 2016 at 11:43 PM, sebb <se...@gmail.com> wrote:
>>
>> On 24 March 2016 at 21:20, Philippe Mouawad <ph...@gmail.com>
>>> wrote:
>>>
>>>> Hello,
>>>> I have asked on mailing list and the answers (3 only) I got all say
>>>> they
>>>> are not used.
>>>> Shall I drop them ?
>>>>
>>> I would prefer to keep jmeter.icons
>>> It's useful for trialling new sets.
>>>
>>> Regards
>>>>
>>>> On Sat, Mar 12, 2016 at 1:52 PM, Philippe Mouawad <
>>>> philippe.mouawad@gmail.com> wrote:
>>>>
>>>> I've sent a mail to users mailing list
>>>>>
>>>>> On Sat, Mar 12, 2016 at 1:44 PM, sebb <se...@gmail.com> wrote:
>>>>>
>>>>> On 11 March 2016 at 20:10, Philippe Mouawad <
>>>>>>
>>>>> philippe.mouawad@gmail.com>
>>>
>>>> wrote:
>>>>>>
>>>>>>> Hello,
>>>>>>> I suggest we drop the following:
>>>>>>>
>>>>>>> - jmeter.toolbar.display
>>>>>>> - jmeter.errorscounter.display
>>>>>>> - jmeter.icons
>>>>>>>
>>>>>>> Because:
>>>>>>>
>>>>>>> 1. Why would somebody not want the toolbar ?
>>>>>>>
>>>>>> Have you asked the users?
>>>>>>
>>>>>> 2. Why would somebody not want the errors counter ?
>>>>>>>
>>>>>> Ditto.
>>>>>>
>>>>>> 3. Do we really need to provide customization of icons ? New ones
>>>>>>>
>>>>>> are
>>>
>>>> nice, that's it
>>>>>>>
>>>>>> They may not suit all tastes or all types of eyesight; why drop the
>>>>>>
>>>>> code?
>>>
>>>> Shouldn't we also merge:
>>>>>>> icons-toolbar.properties and icon.properties ?
>>>>>>>
>>>>>>> We already have a lot of properties.
>>>>>>>
>>>>>>> --
>>>>>>> Cordialement.
>>>>>>> Philippe Mouawad.
>>>>>>>
>>>>>>
>>>>>
>>>>> --
>>>>> Cordialement.
>>>>> Philippe Mouawad.
>>>>>
>>>>>
>>>>>
>>>>>
>>>> --
>>>> Cordialement.
>>>> Philippe Mouawad.
>>>>
>>>
>>
>>
>
--
Cordialement.
Philippe Mouawad.
Re: Drop some properties and merge icon.properties with
icons-toolbar.properties
Posted by Milamber <mi...@apache.org>.
What about the Options menu > Toolbar?
On 25/03/2016 07:45, Philippe Mouawad wrote:
> Hi,
> Ok I will drop :
> - jmeter.toolbar.display
> - jmeter.errorscounter.display
>
> And leave this one but not exposed in jmeter.properties:
> - jmeter.icons
>
> Regards
>
> On Thu, Mar 24, 2016 at 11:43 PM, sebb <se...@gmail.com> wrote:
>
>> On 24 March 2016 at 21:20, Philippe Mouawad <ph...@gmail.com>
>> wrote:
>>> Hello,
>>> I have asked on mailing list and the answers (3 only) I got all say they
>>> are not used.
>>> Shall I drop them ?
>> I would prefer to keep jmeter.icons
>> It's useful for trialling new sets.
>>
>>> Regards
>>>
>>> On Sat, Mar 12, 2016 at 1:52 PM, Philippe Mouawad <
>>> philippe.mouawad@gmail.com> wrote:
>>>
>>>> I've sent a mail to users mailing list
>>>>
>>>> On Sat, Mar 12, 2016 at 1:44 PM, sebb <se...@gmail.com> wrote:
>>>>
>>>>> On 11 March 2016 at 20:10, Philippe Mouawad <
>> philippe.mouawad@gmail.com>
>>>>> wrote:
>>>>>> Hello,
>>>>>> I suggest we drop the following:
>>>>>>
>>>>>> - jmeter.toolbar.display
>>>>>> - jmeter.errorscounter.display
>>>>>> - jmeter.icons
>>>>>>
>>>>>> Because:
>>>>>>
>>>>>> 1. Why would somebody not want the toolbar ?
>>>>> Have you asked the users?
>>>>>
>>>>>> 2. Why would somebody not want the errors counter ?
>>>>> Ditto.
>>>>>
>>>>>> 3. Do we really need to provide customization of icons ? New ones
>> are
>>>>>> nice, that's it
>>>>> They may not suit all tastes or all types of eyesight; why drop the
>> code?
>>>>>> Shouldn't we also merge:
>>>>>> icons-toolbar.properties and icon.properties ?
>>>>>>
>>>>>> We already have a lot of properties.
>>>>>>
>>>>>> --
>>>>>> Cordialement.
>>>>>> Philippe Mouawad.
>>>>
>>>>
>>>> --
>>>> Cordialement.
>>>> Philippe Mouawad.
>>>>
>>>>
>>>>
>>>
>>> --
>>> Cordialement.
>>> Philippe Mouawad.
>
>
Re: Drop some properties and merge icon.properties with icons-toolbar.properties
Posted by Philippe Mouawad <ph...@gmail.com>.
I left it
On Fri, Mar 25, 2016 at 1:28 PM, sebb <se...@gmail.com> wrote:
> On 25 March 2016 at 07:45, Philippe Mouawad <ph...@gmail.com>
> wrote:
> > Hi,
> > Ok I will drop :
> > - jmeter.toolbar.display
> > - jmeter.errorscounter.display
> >
> > And leave this one but not exposed in jmeter.properties:
>
> -1
> Please leave it in jmeter.properties.
>
> > - jmeter.icons
> >
> > Regards
> >
> > On Thu, Mar 24, 2016 at 11:43 PM, sebb <se...@gmail.com> wrote:
> >
> >> On 24 March 2016 at 21:20, Philippe Mouawad <philippe.mouawad@gmail.com
> >
> >> wrote:
> >> > Hello,
> >> > I have asked on mailing list and the answers (3 only) I got all say
> they
> >> > are not used.
> >> > Shall I drop them ?
> >>
> >> I would prefer to keep jmeter.icons
> >> It's useful for trialling new sets.
> >>
> >> > Regards
> >> >
> >> > On Sat, Mar 12, 2016 at 1:52 PM, Philippe Mouawad <
> >> > philippe.mouawad@gmail.com> wrote:
> >> >
> >> >> I've sent a mail to users mailing list
> >> >>
> >> >> On Sat, Mar 12, 2016 at 1:44 PM, sebb <se...@gmail.com> wrote:
> >> >>
> >> >>> On 11 March 2016 at 20:10, Philippe Mouawad <
> >> philippe.mouawad@gmail.com>
> >> >>> wrote:
> >> >>> > Hello,
> >> >>> > I suggest we drop the following:
> >> >>> >
> >> >>> > - jmeter.toolbar.display
> >> >>> > - jmeter.errorscounter.display
> >> >>> > - jmeter.icons
> >> >>> >
> >> >>> > Because:
> >> >>> >
> >> >>> > 1. Why would somebody not want the toolbar ?
> >> >>>
> >> >>> Have you asked the users?
> >> >>>
> >> >>> > 2. Why would somebody not want the errors counter ?
> >> >>>
> >> >>> Ditto.
> >> >>>
> >> >>> > 3. Do we really need to provide customization of icons ? New
> ones
> >> are
> >> >>> > nice, that's it
> >> >>>
> >> >>> They may not suit all tastes or all types of eyesight; why drop the
> >> code?
> >> >>>
> >> >>> >
> >> >>> > Shouldn't we also merge:
> >> >>> > icons-toolbar.properties and icon.properties ?
> >> >>> >
> >> >>> > We already have a lot of properties.
> >> >>> >
> >> >>> > --
> >> >>> > Cordialement.
> >> >>> > Philippe Mouawad.
> >> >>>
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> Cordialement.
> >> >> Philippe Mouawad.
> >> >>
> >> >>
> >> >>
> >> >
> >> >
> >> > --
> >> > Cordialement.
> >> > Philippe Mouawad.
> >>
> >
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
>
--
Cordialement.
Philippe Mouawad.
Re: Drop some properties and merge icon.properties with icons-toolbar.properties
Posted by sebb <se...@gmail.com>.
On 25 March 2016 at 07:45, Philippe Mouawad <ph...@gmail.com> wrote:
> Hi,
> Ok I will drop :
> - jmeter.toolbar.display
> - jmeter.errorscounter.display
>
> And leave this one but not exposed in jmeter.properties:
-1
Please leave it in jmeter.properties.
> - jmeter.icons
>
> Regards
>
> On Thu, Mar 24, 2016 at 11:43 PM, sebb <se...@gmail.com> wrote:
>
>> On 24 March 2016 at 21:20, Philippe Mouawad <ph...@gmail.com>
>> wrote:
>> > Hello,
>> > I have asked on mailing list and the answers (3 only) I got all say they
>> > are not used.
>> > Shall I drop them ?
>>
>> I would prefer to keep jmeter.icons
>> It's useful for trialling new sets.
>>
>> > Regards
>> >
>> > On Sat, Mar 12, 2016 at 1:52 PM, Philippe Mouawad <
>> > philippe.mouawad@gmail.com> wrote:
>> >
>> >> I've sent a mail to users mailing list
>> >>
>> >> On Sat, Mar 12, 2016 at 1:44 PM, sebb <se...@gmail.com> wrote:
>> >>
>> >>> On 11 March 2016 at 20:10, Philippe Mouawad <
>> philippe.mouawad@gmail.com>
>> >>> wrote:
>> >>> > Hello,
>> >>> > I suggest we drop the following:
>> >>> >
>> >>> > - jmeter.toolbar.display
>> >>> > - jmeter.errorscounter.display
>> >>> > - jmeter.icons
>> >>> >
>> >>> > Because:
>> >>> >
>> >>> > 1. Why would somebody not want the toolbar ?
>> >>>
>> >>> Have you asked the users?
>> >>>
>> >>> > 2. Why would somebody not want the errors counter ?
>> >>>
>> >>> Ditto.
>> >>>
>> >>> > 3. Do we really need to provide customization of icons ? New ones
>> are
>> >>> > nice, that's it
>> >>>
>> >>> They may not suit all tastes or all types of eyesight; why drop the
>> code?
>> >>>
>> >>> >
>> >>> > Shouldn't we also merge:
>> >>> > icons-toolbar.properties and icon.properties ?
>> >>> >
>> >>> > We already have a lot of properties.
>> >>> >
>> >>> > --
>> >>> > Cordialement.
>> >>> > Philippe Mouawad.
>> >>>
>> >>
>> >>
>> >>
>> >> --
>> >> Cordialement.
>> >> Philippe Mouawad.
>> >>
>> >>
>> >>
>> >
>> >
>> > --
>> > Cordialement.
>> > Philippe Mouawad.
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
Re: Drop some properties and merge icon.properties with icons-toolbar.properties
Posted by Philippe Mouawad <ph...@gmail.com>.
Hi,
Ok I will drop :
- jmeter.toolbar.display
- jmeter.errorscounter.display
And leave this one but not exposed in jmeter.properties:
- jmeter.icons
Regards
On Thu, Mar 24, 2016 at 11:43 PM, sebb <se...@gmail.com> wrote:
> On 24 March 2016 at 21:20, Philippe Mouawad <ph...@gmail.com>
> wrote:
> > Hello,
> > I have asked on mailing list and the answers (3 only) I got all say they
> > are not used.
> > Shall I drop them ?
>
> I would prefer to keep jmeter.icons
> It's useful for trialling new sets.
>
> > Regards
> >
> > On Sat, Mar 12, 2016 at 1:52 PM, Philippe Mouawad <
> > philippe.mouawad@gmail.com> wrote:
> >
> >> I've sent a mail to users mailing list
> >>
> >> On Sat, Mar 12, 2016 at 1:44 PM, sebb <se...@gmail.com> wrote:
> >>
> >>> On 11 March 2016 at 20:10, Philippe Mouawad <
> philippe.mouawad@gmail.com>
> >>> wrote:
> >>> > Hello,
> >>> > I suggest we drop the following:
> >>> >
> >>> > - jmeter.toolbar.display
> >>> > - jmeter.errorscounter.display
> >>> > - jmeter.icons
> >>> >
> >>> > Because:
> >>> >
> >>> > 1. Why would somebody not want the toolbar ?
> >>>
> >>> Have you asked the users?
> >>>
> >>> > 2. Why would somebody not want the errors counter ?
> >>>
> >>> Ditto.
> >>>
> >>> > 3. Do we really need to provide customization of icons ? New ones
> are
> >>> > nice, that's it
> >>>
> >>> They may not suit all tastes or all types of eyesight; why drop the
> code?
> >>>
> >>> >
> >>> > Shouldn't we also merge:
> >>> > icons-toolbar.properties and icon.properties ?
> >>> >
> >>> > We already have a lot of properties.
> >>> >
> >>> > --
> >>> > Cordialement.
> >>> > Philippe Mouawad.
> >>>
> >>
> >>
> >>
> >> --
> >> Cordialement.
> >> Philippe Mouawad.
> >>
> >>
> >>
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
>
--
Cordialement.
Philippe Mouawad.
Re: Drop some properties and merge icon.properties with icons-toolbar.properties
Posted by sebb <se...@gmail.com>.
On 24 March 2016 at 21:20, Philippe Mouawad <ph...@gmail.com> wrote:
> Hello,
> I have asked on mailing list and the answers (3 only) I got all say they
> are not used.
> Shall I drop them ?
I would prefer to keep jmeter.icons
It's useful for trialling new sets.
> Regards
>
> On Sat, Mar 12, 2016 at 1:52 PM, Philippe Mouawad <
> philippe.mouawad@gmail.com> wrote:
>
>> I've sent a mail to users mailing list
>>
>> On Sat, Mar 12, 2016 at 1:44 PM, sebb <se...@gmail.com> wrote:
>>
>>> On 11 March 2016 at 20:10, Philippe Mouawad <ph...@gmail.com>
>>> wrote:
>>> > Hello,
>>> > I suggest we drop the following:
>>> >
>>> > - jmeter.toolbar.display
>>> > - jmeter.errorscounter.display
>>> > - jmeter.icons
>>> >
>>> > Because:
>>> >
>>> > 1. Why would somebody not want the toolbar ?
>>>
>>> Have you asked the users?
>>>
>>> > 2. Why would somebody not want the errors counter ?
>>>
>>> Ditto.
>>>
>>> > 3. Do we really need to provide customization of icons ? New ones are
>>> > nice, that's it
>>>
>>> They may not suit all tastes or all types of eyesight; why drop the code?
>>>
>>> >
>>> > Shouldn't we also merge:
>>> > icons-toolbar.properties and icon.properties ?
>>> >
>>> > We already have a lot of properties.
>>> >
>>> > --
>>> > Cordialement.
>>> > Philippe Mouawad.
>>>
>>
>>
>>
>> --
>> Cordialement.
>> Philippe Mouawad.
>>
>>
>>
>
>
> --
> Cordialement.
> Philippe Mouawad.
Re: Drop some properties and merge icon.properties with icons-toolbar.properties
Posted by Philippe Mouawad <ph...@gmail.com>.
Hello,
I have asked on mailing list and the answers (3 only) I got all say they
are not used.
Shall I drop them ?
Regards
On Sat, Mar 12, 2016 at 1:52 PM, Philippe Mouawad <
philippe.mouawad@gmail.com> wrote:
> I've sent a mail to users mailing list
>
> On Sat, Mar 12, 2016 at 1:44 PM, sebb <se...@gmail.com> wrote:
>
>> On 11 March 2016 at 20:10, Philippe Mouawad <ph...@gmail.com>
>> wrote:
>> > Hello,
>> > I suggest we drop the following:
>> >
>> > - jmeter.toolbar.display
>> > - jmeter.errorscounter.display
>> > - jmeter.icons
>> >
>> > Because:
>> >
>> > 1. Why would somebody not want the toolbar ?
>>
>> Have you asked the users?
>>
>> > 2. Why would somebody not want the errors counter ?
>>
>> Ditto.
>>
>> > 3. Do we really need to provide customization of icons ? New ones are
>> > nice, that's it
>>
>> They may not suit all tastes or all types of eyesight; why drop the code?
>>
>> >
>> > Shouldn't we also merge:
>> > icons-toolbar.properties and icon.properties ?
>> >
>> > We already have a lot of properties.
>> >
>> > --
>> > Cordialement.
>> > Philippe Mouawad.
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>
--
Cordialement.
Philippe Mouawad.
Re: Drop some properties and merge icon.properties with icons-toolbar.properties
Posted by Philippe Mouawad <ph...@gmail.com>.
I've sent a mail to users mailing list
On Sat, Mar 12, 2016 at 1:44 PM, sebb <se...@gmail.com> wrote:
> On 11 March 2016 at 20:10, Philippe Mouawad <ph...@gmail.com>
> wrote:
> > Hello,
> > I suggest we drop the following:
> >
> > - jmeter.toolbar.display
> > - jmeter.errorscounter.display
> > - jmeter.icons
> >
> > Because:
> >
> > 1. Why would somebody not want the toolbar ?
>
> Have you asked the users?
>
> > 2. Why would somebody not want the errors counter ?
>
> Ditto.
>
> > 3. Do we really need to provide customization of icons ? New ones are
> > nice, that's it
>
> They may not suit all tastes or all types of eyesight; why drop the code?
>
> >
> > Shouldn't we also merge:
> > icons-toolbar.properties and icon.properties ?
> >
> > We already have a lot of properties.
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
>
--
Cordialement.
Philippe Mouawad.
Re: Drop some properties and merge icon.properties with icons-toolbar.properties
Posted by sebb <se...@gmail.com>.
On 11 March 2016 at 20:10, Philippe Mouawad <ph...@gmail.com> wrote:
> Hello,
> I suggest we drop the following:
>
> - jmeter.toolbar.display
> - jmeter.errorscounter.display
> - jmeter.icons
>
> Because:
>
> 1. Why would somebody not want the toolbar ?
Have you asked the users?
> 2. Why would somebody not want the errors counter ?
Ditto.
> 3. Do we really need to provide customization of icons ? New ones are
> nice, that's it
They may not suit all tastes or all types of eyesight; why drop the code?
>
> Shouldn't we also merge:
> icons-toolbar.properties and icon.properties ?
>
> We already have a lot of properties.
>
> --
> Cordialement.
> Philippe Mouawad.