You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/03/09 14:07:29 UTC
[GitHub] [shardingsphere] Girlwithasmile opened a new pull request #15945: Updated _index.cn.md
Girlwithasmile opened a new pull request #15945:
URL: https://github.com/apache/shardingsphere/pull/15945
Fixes #ISSUSE_ID. #15923
Changes proposed in this pull request:
- Space between English and Chinese words
-
-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #15945: Updated _index.cn.md
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #15945:
URL: https://github.com/apache/shardingsphere/pull/15945#discussion_r822708526
##########
File path: docs/document/content/features/readwrite-splitting/_index.cn.md
##########
@@ -15,7 +15,7 @@ chapter = true
与将数据根据分片键打散至各个数据节点的水平分片不同，读写分离则是根据SQL语义的分析，将读操作和写操作分别路由至主库与从库。
-
+![背景] (https://shardingsphere.apache.org/document/current/img/readwrite-splitting/background.png)
Review comment:
Please do not remove space between `[背景]` and `(https://shardingsphere.apache.org/document/current/img/readwrite-splitting/background.png)`, which is markdown syntax
##########
File path: docs/document/content/features/readwrite-splitting/_index.cn.md
##########
@@ -26,8 +26,8 @@ chapter = true
并且，读写分离也带来了与数据分片同样的问题，它同样会使得应用开发和运维人员对数据库的操作和运维变得更加复杂。
下图展现了将数据分片与读写分离一同使用时，应用程序与数据库集群之间的复杂拓扑关系。
-
+![挑战] (https://shardingsphere.apache.org/document/current/img/readwrite-splitting/challenges.png)
## 目标
-**透明化读写分离所带来的影响，让使用方尽量像使用一个数据库一样使用主从数据库集群，是 Apache ShardingSphere 读写分离模块的主要设计目标。**
+**透明化读写分离所带来的影响，让使用方尽量像使用一个数据库一样使用主从数据库集群，是 Apache ShardingSphere 读写分离模块的主要设计目标。**
Review comment:
Why change to 2 spaces here?
##########
File path: docs/document/content/features/readwrite-splitting/_index.cn.md
##########
@@ -26,8 +26,8 @@ chapter = true
并且，读写分离也带来了与数据分片同样的问题，它同样会使得应用开发和运维人员对数据库的操作和运维变得更加复杂。
下图展现了将数据分片与读写分离一同使用时，应用程序与数据库集群之间的复杂拓扑关系。
-
+![挑战] (https://shardingsphere.apache.org/document/current/img/readwrite-splitting/challenges.png)
Review comment:
Please do not remove space between `[挑战]` and `(https://shardingsphere.apache.org/document/current/img/readwrite-splitting/challenges.png)`, which is markdown syntax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #15945: Updated _index.cn.md
Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #15945:
URL: https://github.com/apache/shardingsphere/pull/15945#issuecomment-1063653138
After revert, there are nothing changed, maybe we can close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed pull request #15945: Updated _index.cn.md
Posted by GitBox <gi...@apache.org>.
terrymanu closed pull request #15945:
URL: https://github.com/apache/shardingsphere/pull/15945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org