You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2019/09/06 09:19:01 UTC
Review Request 71442: RANGER-2554 : Log out message for Ranger needs
to be more informative on Knox enabled cluster
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71442/
-----------------------------------------------------------
Review request for ranger, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
Bugs: RANGER-2554
https://issues.apache.org/jira/browse/RANGER-2554
Repository: ranger
Description
-------
On a Knox enabled cluster, Ranger log out functionality needs to be more informative.
In the case of Ranger UI, the 'log out' button does nothing and keeps the user on the same page.
In this case, the RANGER UI message on trying to log out seems to be informative enough for the user, informing the user as what the expected behaviour would be in case of Knox enabled cluster.
Diffs
-----
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 4096020
security-admin/src/main/webapp/scripts/views/common/ErrorView.js 4f8f463
security-admin/src/main/webapp/scripts/views/common/ProfileBar.js 4a8aed5
security-admin/src/main/webapp/styles/xa.css 2081afe
security-admin/src/main/webapp/templates/common/ErrorView_tmpl.html e565903
Diff: https://reviews.apache.org/r/71442/diff/1/
Testing
-------
Testing done
1.Simple Ranger login and logout.
2.Ranger login and logout when KnoxSSO enabled.
Thanks,
Nitin Galave
Re: Review Request 71442: RANGER-2554 : Log out message for Ranger
needs to be more informative on Knox enabled cluster
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71442/#review217648
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On Sept. 6, 2019, 9:19 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71442/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2019, 9:19 a.m.)
>
>
> Review request for ranger, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2554
> https://issues.apache.org/jira/browse/RANGER-2554
>
>
> Repository: ranger
>
>
> Description
> -------
>
> On a Knox enabled cluster, Ranger log out functionality needs to be more informative.
> In the case of Ranger UI, the 'log out' button does nothing and keeps the user on the same page.
>
> In this case, the RANGER UI message on trying to log out seems to be informative enough for the user, informing the user as what the expected behaviour would be in case of Knox enabled cluster.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 4096020
> security-admin/src/main/webapp/scripts/views/common/ErrorView.js 4f8f463
> security-admin/src/main/webapp/scripts/views/common/ProfileBar.js 4a8aed5
> security-admin/src/main/webapp/styles/xa.css 2081afe
> security-admin/src/main/webapp/templates/common/ErrorView_tmpl.html e565903
>
>
> Diff: https://reviews.apache.org/r/71442/diff/1/
>
>
> Testing
> -------
>
> Testing done
> 1.Simple Ranger login and logout.
> 2.Ranger login and logout when KnoxSSO enabled.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 71442: RANGER-2554 : Log out message for Ranger
needs to be more informative on Knox enabled cluster
Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71442/#review217631
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On Sept. 6, 2019, 9:19 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71442/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2019, 9:19 a.m.)
>
>
> Review request for ranger, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2554
> https://issues.apache.org/jira/browse/RANGER-2554
>
>
> Repository: ranger
>
>
> Description
> -------
>
> On a Knox enabled cluster, Ranger log out functionality needs to be more informative.
> In the case of Ranger UI, the 'log out' button does nothing and keeps the user on the same page.
>
> In this case, the RANGER UI message on trying to log out seems to be informative enough for the user, informing the user as what the expected behaviour would be in case of Knox enabled cluster.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 4096020
> security-admin/src/main/webapp/scripts/views/common/ErrorView.js 4f8f463
> security-admin/src/main/webapp/scripts/views/common/ProfileBar.js 4a8aed5
> security-admin/src/main/webapp/styles/xa.css 2081afe
> security-admin/src/main/webapp/templates/common/ErrorView_tmpl.html e565903
>
>
> Diff: https://reviews.apache.org/r/71442/diff/1/
>
>
> Testing
> -------
>
> Testing done
> 1.Simple Ranger login and logout.
> 2.Ranger login and logout when KnoxSSO enabled.
>
>
> Thanks,
>
> Nitin Galave
>
>