You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Wes Wannemacher <we...@wantii.com> on 2009/02/25 16:12:42 UTC
XWork test failures
Now that we are depending on the xwork snapshot, I went ahead and
setup an XWork build in Hudson, just like the struts2 builds.
The test failures are showing up there, but I can't reproduce them...
Well, I can, they fail when you run the build with Maven, but if you
run the tests individually, like in Eclipse, they pass. The test
failures are here -
http://hudson.zones.apache.org/hudson/job/xwork2/2/#showFailuresLink
-Wes
--
Wes Wannemacher
Author - Struts 2 In Practice
Includes coverage of Struts 2.1, Spring, JPA, JQuery, Sitemesh and more
http://www.manning.com/wannemacher
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Wes Wannemacher <we...@wantii.com>.
On Wed, Feb 25, 2009 at 11:14 AM, Musachy Barroso <mu...@gmail.com> wrote:
> Yeah, I overloaded a constructor and used it in Convention.
>
I don't think it's the change that killed it, just the fact that the
XWork snapshot isn't in Bamboo's repo because it's build is failing.
-Wes
--
Wes Wannemacher
Author - Struts 2 In Practice
Includes coverage of Struts 2.1, Spring, JPA, JQuery, Sitemesh and more
http://www.manning.com/wannemacher
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Musachy Barroso <mu...@gmail.com>.
Yeah, I overloaded a constructor and used it in Convention.
On Wed, Feb 25, 2009 at 11:08 AM, Wes Wannemacher <we...@wantii.com> wrote:
> On Wed, Feb 25, 2009 at 10:58 AM, Rene Gielen <gi...@it-neering.net> wrote:
>> Same here. Is the failing Hudson snapshot build also the reason why the
>> S2.1 Bamboo build is still failing? Bamboo build isn't able to get the
>> XWork update with Musachy's latest XW commit, needed for S2 build.
>>
>> Am Mi, 25.02.2009, 16:34, schrieb Musachy Barroso:
>>> The overflow test might be related to a bug Lucasz fixed about double
>>> conversion on negative numbers. The others pass in IntelliJ and fail
>>> with maven, so yeah something is up.
>>>
>>> musachy
>>>
>
> Looks like Bamboo is choking on the same problems in XWork as Hudson,
> but as far as Struts2 is concerned, it has a compile failure (symbol
> not found), so I'm guessing that when we get XWork to build, it may
> work itself out... The symbol not found is -
>
> com.opensymphony.xwork2.util.finder.ClassFinder
>
> -Wes
>
> --
> Wes Wannemacher
> Author - Struts 2 In Practice
> Includes coverage of Struts 2.1, Spring, JPA, JQuery, Sitemesh and more
> http://www.manning.com/wannemacher
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Wes Wannemacher <we...@wantii.com>.
On Wed, Feb 25, 2009 at 10:58 AM, Rene Gielen <gi...@it-neering.net> wrote:
> Same here. Is the failing Hudson snapshot build also the reason why the
> S2.1 Bamboo build is still failing? Bamboo build isn't able to get the
> XWork update with Musachy's latest XW commit, needed for S2 build.
>
> Am Mi, 25.02.2009, 16:34, schrieb Musachy Barroso:
>> The overflow test might be related to a bug Lucasz fixed about double
>> conversion on negative numbers. The others pass in IntelliJ and fail
>> with maven, so yeah something is up.
>>
>> musachy
>>
Looks like Bamboo is choking on the same problems in XWork as Hudson,
but as far as Struts2 is concerned, it has a compile failure (symbol
not found), so I'm guessing that when we get XWork to build, it may
work itself out... The symbol not found is -
com.opensymphony.xwork2.util.finder.ClassFinder
-Wes
--
Wes Wannemacher
Author - Struts 2 In Practice
Includes coverage of Struts 2.1, Spring, JPA, JQuery, Sitemesh and more
http://www.manning.com/wannemacher
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Rene Gielen <gi...@it-neering.net>.
Same here. Is the failing Hudson snapshot build also the reason why the
S2.1 Bamboo build is still failing? Bamboo build isn't able to get the
XWork update with Musachy's latest XW commit, needed for S2 build.
Am Mi, 25.02.2009, 16:34, schrieb Musachy Barroso:
> The overflow test might be related to a bug Lucasz fixed about double
> conversion on negative numbers. The others pass in IntelliJ and fail
> with maven, so yeah something is up.
>
> musachy
>
> On Wed, Feb 25, 2009 at 10:12 AM, Wes Wannemacher <we...@wantii.com> wrote:
>> Now that we are depending on the xwork snapshot, I went ahead and
>> setup an XWork build in Hudson, just like the struts2 builds.
>>
>> The test failures are showing up there, but I can't reproduce them...
>> Well, I can, they fail when you run the build with Maven, but if you
>> run the tests individually, like in Eclipse, they pass. The test
>> failures are here -
>>
>> http://hudson.zones.apache.org/hudson/job/xwork2/2/#showFailuresLink
>>
>> -Wes
>>
>> --
>> Wes Wannemacher
>> Author - Struts 2 In Practice
>> Includes coverage of Struts 2.1, Spring, JPA, JQuery, Sitemesh and more
>> http://www.manning.com/wannemacher
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
>
> --
> "Hey you! Would you help me to carry the stone?" Pink Floyd
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
--
René Gielen
IT-Neering.net
Saarstrasse 100, 52062 Aachen, Germany
Tel: +49-(0)241-4010770
Fax: +49-(0)241-4010771
Cel: +49-(0)177-3194448
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Musachy Barroso <mu...@gmail.com>.
The overflow test might be related to a bug Lucasz fixed about double
conversion on negative numbers. The others pass in IntelliJ and fail
with maven, so yeah something is up.
musachy
On Wed, Feb 25, 2009 at 10:12 AM, Wes Wannemacher <we...@wantii.com> wrote:
> Now that we are depending on the xwork snapshot, I went ahead and
> setup an XWork build in Hudson, just like the struts2 builds.
>
> The test failures are showing up there, but I can't reproduce them...
> Well, I can, they fail when you run the build with Maven, but if you
> run the tests individually, like in Eclipse, they pass. The test
> failures are here -
>
> http://hudson.zones.apache.org/hudson/job/xwork2/2/#showFailuresLink
>
> -Wes
>
> --
> Wes Wannemacher
> Author - Struts 2 In Practice
> Includes coverage of Struts 2.1, Spring, JPA, JQuery, Sitemesh and more
> http://www.manning.com/wannemacher
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Musachy Barroso <mu...@gmail.com>.
It is working for me after your last change. Thanks :)
musachy
On Thu, Feb 26, 2009 at 5:36 PM, Lukasz Lenart
<lu...@googlemail.com> wrote:
> 2009/2/26 Musachy Barroso <mu...@gmail.com>:
>> It has something to do with forking in the surefire plugin, running
>> the tests without forking works(for me at least):
>>
>> mvn test -DforkMode=none
>
> If my change don't solve the problem, I think we should switch back
> the fork mode.
>
>
> Regards
> --
> Lukasz
> http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Lukasz Lenart <lu...@googlemail.com>.
2009/2/26 Musachy Barroso <mu...@gmail.com>:
> It has something to do with forking in the surefire plugin, running
> the tests without forking works(for me at least):
>
> mvn test -DforkMode=none
If my change don't solve the problem, I think we should switch back
the fork mode.
Regards
--
Lukasz
http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Lukasz Lenart <lu...@googlemail.com>.
2009/3/13 Musachy Barroso <mu...@gmail.com>:
> Me forgetting something? pfft, what are we talking about again?
:D:D:D:D
Regards
--
Lukasz
http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Musachy Barroso <mu...@gmail.com>.
On Thu, Mar 12, 2009 at 8:06 PM, Wes Wannemacher <we...@wantii.com> wrote:
> It'd probably be sufficient to file a JIRA against it, just so that we don't
> forget in the future that we should fix it up.
Me forgetting something? pfft, what are we talking about again?
musachy
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Lukasz Lenart <lu...@googlemail.com>.
I committed pom.xml with excluded URUtilTest, that solved all the
problems and also updated Surefire plugin to version 2.4.2
Regards
--
Lukasz
http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Lukasz Lenart <lu...@googlemail.com>.
2009/3/13 Wes Wannemacher <we...@wantii.com>:
> On Thursday 12 March 2009 19:35:37 Musachy Barroso wrote:
>> Yeah, I have to find a better way to test those dumb URLs with weird
>> protocols. Is there a problem running with "pertest"?
> I don't see a problem with it, so long as we know why we're doing it. The key
> seems to be in the javadocs for URL, it states -
I've been thinking about setting forkMode to "pertest" and it can hide
some errors (like this with URLUtilTest). If someone will do the same
but with normal class (not with test), it will be discovered during
application runtime (at least), not during tests. The best option, I
suppose, is to set two kind of tests - which need forkMode to be set
"pertest" and which don't. I don't know if it's possible to do with
surefire plugin.
Regards
--
Lukasz
http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Wes Wannemacher <we...@wantii.com>.
On Thursday 12 March 2009 19:35:37 Musachy Barroso wrote:
> Yeah, I have to find a better way to test those dumb URLs with weird
> protocols. Is there a problem running with "pertest"?
>
> musachy
>
I don't see a problem with it, so long as we know why we're doing it. The key
seems to be in the javadocs for URL, it states -
"This method can be called at most once in a given Java Virtual Machine. "
Which pretty much means that since the inner class in URLTest that acts as a
factory returns null, like Lukasz said, anything afterwards is not going to
get a stream handler.
It'd probably be sufficient to file a JIRA against it, just so that we don't
forget in the future that we should fix it up.
-Wes
--
Wes Wannemacher
Author - Struts 2 In Practice
Includes coverage of Struts 2.1, Spring, JPA, JQuery, Sitemesh and more
http://www.manning.com/wannemacher
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Musachy Barroso <mu...@gmail.com>.
Yeah, I have to find a better way to test those dumb URLs with weird
protocols. Is there a problem running with "pertest"?
musachy
On Thu, Mar 12, 2009 at 6:26 PM, Lukasz Lenart
<lu...@googlemail.com> wrote:
> 2009/3/1 Lukasz Lenart <lu...@googlemail.com>:
>> I found solution, just set fork mode to pretest, like below
>>
>> <forkMode>pertest</forkMode>
>>
>> but I think it isn't a real solution.
>
> The real problem is with URLUtilTest.setUp(), in such method
> URL.setURLStreamHandlerFactory() is called to setup some test factory,
> which always return null. All test executed after URLUtilTest and
> which required access to URL will fail ;-(
>
> To solve that problem, the forkMode has to be setup as above or such
> test has to be excluded from Surefire run.
>
> What do you think?
>
>
> Regards
> --
> Lukasz
> http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Lukasz Lenart <lu...@googlemail.com>.
2009/3/1 Lukasz Lenart <lu...@googlemail.com>:
> I found solution, just set fork mode to pretest, like below
>
> <forkMode>pertest</forkMode>
>
> but I think it isn't a real solution.
The real problem is with URLUtilTest.setUp(), in such method
URL.setURLStreamHandlerFactory() is called to setup some test factory,
which always return null. All test executed after URLUtilTest and
which required access to URL will fail ;-(
To solve that problem, the forkMode has to be setup as above or such
test has to be excluded from Surefire run.
What do you think?
Regards
--
Lukasz
http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Wes Wannemacher <we...@wantii.com>.
On Friday 27 February 2009 02:37:39 Lukasz Lenart wrote:
>
> ehhh... sorry but I don't understand, I have already account in JIRA
> or you are talking about something else? Another thing, I sent my CLA
> months ago to apache.org and didn't get any answer, what can I do
> else?
>
Sorry Lukasz, I thought you were a committer... Are you a committer on any
other apache projects, I think you have to be to gain access to Hudson. It
includes both a login for hudson and an ssh account on the host (well the
zone) that runs hudson.
If your goal is to become a committer, keep the patches coming, we appreciate
it!
-Wes
--
Wes Wannemacher
Author - Struts 2 In Practice
Includes coverage of Struts 2.1, Spring, JPA, JQuery, Sitemesh and more
http://www.manning.com/wannemacher
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Lukasz Lenart <lu...@googlemail.com>.
2009/2/27 Wes Wannemacher <we...@wantii.com>:
>> Jared means xwork config files in JAR files ;-) I changed the name to
>> be more readable.
>
> I was just messing around... You know, being a spelling nazi, I assumed you
> meant jarred files. :)
I understand and that's good, thanks for your point ;-)
> I'll kick off the build manually, it's quite easy, you log in, then click
> 'Build Now' in the xwork project. It's pretty easy to get an account on
> hudson, I think you just file a JIRA on INFRA. Their setup is pretty simple,
> if you have an account, you can do just about anything with any project
> building on there.
ehhh... sorry but I don't understand, I have already account in JIRA
or you are talking about something else? Another thing, I sent my CLA
months ago to apache.org and didn't get any answer, what can I do
else?
Regards
--
Lukasz
http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Wes Wannemacher <we...@wantii.com>.
On Thursday 26 February 2009 17:27:09 Lukasz Lenart wrote:
> 2009/2/26 Wes Wannemacher <we...@wantii.com>:
> > testJaredFiles is still failing... (Who is Jared? Maybe we should ask
> > him what is up with his files... j/k). It's the only test still
> > failing on Hudson.
>
> Jared means xwork config files in JAR files ;-) I changed the name to
> be more readable.
I was just messing around... You know, being a spelling nazi, I assumed you
meant jarred files. :)
>
> I think I solved the problem, some helpful explanation is here [1], I
> updated Xwork pom, is there a way to start Xwork build by hand on
> Hudson?
>
I tried to put all the important info up on the wiki -
http://struts.apache.org/2.x/docs/apache-struts-pseudo-nightly-builds-on-
apache-hudson.html
I'll kick off the build manually, it's quite easy, you log in, then click
'Build Now' in the xwork project. It's pretty easy to get an account on
hudson, I think you just file a JIRA on INFRA. Their setup is pretty simple,
if you have an account, you can do just about anything with any project
building on there.
-Wes
--
Wes Wannemacher
Author - Struts 2 In Practice
Includes coverage of Struts 2.1, Spring, JPA, JQuery, Sitemesh and more
http://www.manning.com/wannemacher
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Lukasz Lenart <lu...@googlemail.com>.
When I updated my local copy, such tests below are failing, before
that, there wasn't any problem
testGetSnippetNoPadding(com.opensymphony.xwork2.util.location.LocationImplTest)
testGetSnippet(com.opensymphony.xwork2.util.location.LocationImplTest)
testParserWithBadXML(com.opensymphony.xwork2.validator.DefaultValidatorFileParserTest)
testParserWithBadXML2(com.opensymphony.xwork2.validator.DefaultValidatorFileParserTest)
testValidatorDefinitionsWithBadClassName(com.opensymphony.xwork2.validator.DefaultValidatorFileParserTest)
testParserWithBadValidation(com.opensymphony.xwork2.validator.DefaultValidatorFileParserTest)
Regards
--
Lukasz
http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Musachy Barroso <mu...@gmail.com>.
I am getting new errors(only fail from cmd line), not sure what is going on:
testGetSnippetNoPadding(com.opensymphony.xwork2.util.location.LocationImplTest)
testGetSnippet(com.opensymphony.xwork2.util.location.LocationImplTest)
testParserWithBadXML2(com.opensymphony.xwork2.validator.DefaultValidatorFileParserTest)
musachy
On Fri, Feb 27, 2009 at 9:40 AM, Wes Wannemacher <we...@wantii.com> wrote:
> Ooops, only replied to Lukasz the first time, here's some additional info -
>
>
> ---------- Forwarded message ----------
> From: Wes Wannemacher <we...@wantii.com>
> Date: Fri, Feb 27, 2009 at 9:39 AM
> Subject: Re: XWork test failures
> To: Lukasz Lenart <lu...@googlemail.com>
>
>
> That build ran without any forkmode setting... Here is how Hudson ran it -
>
> [xwork] $ /home/hudson/tools/java/latest1.6/bin/java -Xms128m -Xmx768m
> -XX:MaxPermSize=256m -XX:PermSize=128m [-cp classpath snipped for
> brevity]
> Executing Maven: -B -B -f
> /export/home/hudson/hudson/jobs/xwork2/workspace/xwork/pom.xml -Pall
> clean install
>
> You can check the console output here -
> http://hudson.zones.apache.org/hudson/view/Struts/job/xwork2/lastBuild/console
>
> -Wes
>
> On Fri, Feb 27, 2009 at 3:25 AM, Lukasz Lenart
> <lu...@googlemail.com> wrote:
>> 2009/2/27 Wes Wannemacher <we...@wantii.com>:
>>> http://hudson.zones.apache.org/hudson/view/Struts/job/xwork2/5/
>>>
>>> There are some new tests failing :(
>>>
>>> It appears related, I'll check into it, if I don't fall asleep first.
>>
>> Could you remove the setting for forkMode? I think this can be related
>> to (from [1]):
>> Check your forkMode. If forkMode=never, it's impossible to use the
>> system classloader; we have to use an isolated classloader.
>>
>> [1] http://docs.codehaus.org/display/MAVENUSER/Classloading+and+Forking+under+Maven+Surefire
>>
>>
>> Regards
>> --
>> Lukasz
>> http://www.lenart.org.pl/
>>
>
>
>
> --
> Wes Wannemacher
> Author - Struts 2 In Practice
> Includes coverage of Struts 2.1, Spring, JPA, JQuery, Sitemesh and more
> http://www.manning.com/wannemacher
>
>
>
> --
> Wes Wannemacher
> Author - Struts 2 In Practice
> Includes coverage of Struts 2.1, Spring, JPA, JQuery, Sitemesh and more
> http://www.manning.com/wannemacher
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Fwd: XWork test failures
Posted by Wes Wannemacher <we...@wantii.com>.
Ooops, only replied to Lukasz the first time, here's some additional info -
---------- Forwarded message ----------
From: Wes Wannemacher <we...@wantii.com>
Date: Fri, Feb 27, 2009 at 9:39 AM
Subject: Re: XWork test failures
To: Lukasz Lenart <lu...@googlemail.com>
That build ran without any forkmode setting... Here is how Hudson ran it -
[xwork] $ /home/hudson/tools/java/latest1.6/bin/java -Xms128m -Xmx768m
-XX:MaxPermSize=256m -XX:PermSize=128m [-cp classpath snipped for
brevity]
Executing Maven: -B -B -f
/export/home/hudson/hudson/jobs/xwork2/workspace/xwork/pom.xml -Pall
clean install
You can check the console output here -
http://hudson.zones.apache.org/hudson/view/Struts/job/xwork2/lastBuild/console
-Wes
On Fri, Feb 27, 2009 at 3:25 AM, Lukasz Lenart
<lu...@googlemail.com> wrote:
> 2009/2/27 Wes Wannemacher <we...@wantii.com>:
>> http://hudson.zones.apache.org/hudson/view/Struts/job/xwork2/5/
>>
>> There are some new tests failing :(
>>
>> It appears related, I'll check into it, if I don't fall asleep first.
>
> Could you remove the setting for forkMode? I think this can be related
> to (from [1]):
> Check your forkMode. If forkMode=never, it's impossible to use the
> system classloader; we have to use an isolated classloader.
>
> [1] http://docs.codehaus.org/display/MAVENUSER/Classloading+and+Forking+under+Maven+Surefire
>
>
> Regards
> --
> Lukasz
> http://www.lenart.org.pl/
>
--
Wes Wannemacher
Author - Struts 2 In Practice
Includes coverage of Struts 2.1, Spring, JPA, JQuery, Sitemesh and more
http://www.manning.com/wannemacher
--
Wes Wannemacher
Author - Struts 2 In Practice
Includes coverage of Struts 2.1, Spring, JPA, JQuery, Sitemesh and more
http://www.manning.com/wannemacher
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Lukasz Lenart <lu...@googlemail.com>.
2009/2/27 Wes Wannemacher <we...@wantii.com>:
> http://hudson.zones.apache.org/hudson/view/Struts/job/xwork2/5/
>
> There are some new tests failing :(
>
> It appears related, I'll check into it, if I don't fall asleep first.
Could you remove the setting for forkMode? I think this can be related
to (from [1]):
Check your forkMode. If forkMode=never, it's impossible to use the
system classloader; we have to use an isolated classloader.
[1] http://docs.codehaus.org/display/MAVENUSER/Classloading+and+Forking+under+Maven+Surefire
Regards
--
Lukasz
http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Lukasz Lenart <lu...@googlemail.com>.
2009/2/27 Wes Wannemacher <we...@wantii.com>:
> http://hudson.zones.apache.org/hudson/view/Struts/job/xwork2/5/
>
> There are some new tests failing :(
>
> It appears related, I'll check into it, if I don't fall asleep first.
They base on additional jar files added to classpath with Surefire and
it looks like that those files disappear [1] from classpath on hudson
;-(
I'll dig into later in the train
[1] http://hudson.zones.apache.org/hudson/job/xwork2/com.opensymphony$xwork/5/testReport/com.opensymphony.xwork2.config.providers/XmlConfigurationProviderTest/testConfigsInJarFiles/
Regards
--
Lukasz
http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Wes Wannemacher <we...@wantii.com>.
On Thursday 26 February 2009 17:27:09 Lukasz Lenart wrote:
> 2009/2/26 Wes Wannemacher <we...@wantii.com>:
> > testJaredFiles is still failing... (Who is Jared? Maybe we should ask
> > him what is up with his files... j/k). It's the only test still
> > failing on Hudson.
>
> Jared means xwork config files in JAR files ;-) I changed the name to
> be more readable.
>
> I think I solved the problem, some helpful explanation is here [1], I
> updated Xwork pom, is there a way to start Xwork build by hand on
> Hudson?
http://hudson.zones.apache.org/hudson/view/Struts/job/xwork2/5/
There are some new tests failing :(
It appears related, I'll check into it, if I don't fall asleep first.
-Wes
--
Wes Wannemacher
Author - Struts 2 In Practice
Includes coverage of Struts 2.1, Spring, JPA, JQuery, Sitemesh and more
http://www.manning.com/wannemacher
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Lukasz Lenart <lu...@googlemail.com>.
2009/2/26 Wes Wannemacher <we...@wantii.com>:
> testJaredFiles is still failing... (Who is Jared? Maybe we should ask
> him what is up with his files... j/k). It's the only test still
> failing on Hudson.
Jared means xwork config files in JAR files ;-) I changed the name to
be more readable.
I think I solved the problem, some helpful explanation is here [1], I
updated Xwork pom, is there a way to start Xwork build by hand on
Hudson?
[1] http://docs.codehaus.org/display/MAVENUSER/Classloading+and+Forking+under+Maven+Surefire
Regards
--
Lukasz
http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Musachy Barroso <mu...@gmail.com>.
testJaredFiles could be related to the FileManager changes, that line:
FileManager.setReloadingConfigs(true);
is suspicious. It works for me on Windows XP (/cry).
On Thu, Feb 26, 2009 at 11:14 AM, Wes Wannemacher <we...@wantii.com> wrote:
> On Thu, Feb 26, 2009 at 11:05 AM, Musachy Barroso <mu...@gmail.com> wrote:
>> It has something to do with forking in the surefire plugin, running
>> the tests without forking works(for me at least):
>>
>> mvn test -DforkMode=none
>>
>> musachy
>
> I added that to Hudson and it appears to be working better...
>
>>>
>>>> testJaredFiles - is strange for me, there wasn't problem, but I will
>>>> double-check
>>>
>>> No clue, what is wrong, locally it works (from cmd and with IDEA), I'm
>>> using Maven 2.0.8, I will try to update to latest version and I will
>>> see
>>>
>
> testJaredFiles is still failing... (Who is Jared? Maybe we should ask
> him what is up with his files... j/k). It's the only test still
> failing on Hudson.
>
> -Wes
>
> --
> Wes Wannemacher
> Author - Struts 2 In Practice
> Includes coverage of Struts 2.1, Spring, JPA, JQuery, Sitemesh and more
> http://www.manning.com/wannemacher
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Wes Wannemacher <we...@wantii.com>.
On Thu, Feb 26, 2009 at 11:05 AM, Musachy Barroso <mu...@gmail.com> wrote:
> It has something to do with forking in the surefire plugin, running
> the tests without forking works(for me at least):
>
> mvn test -DforkMode=none
>
> musachy
I added that to Hudson and it appears to be working better...
>>
>>> testJaredFiles - is strange for me, there wasn't problem, but I will
>>> double-check
>>
>> No clue, what is wrong, locally it works (from cmd and with IDEA), I'm
>> using Maven 2.0.8, I will try to update to latest version and I will
>> see
>>
testJaredFiles is still failing... (Who is Jared? Maybe we should ask
him what is up with his files... j/k). It's the only test still
failing on Hudson.
-Wes
--
Wes Wannemacher
Author - Struts 2 In Practice
Includes coverage of Struts 2.1, Spring, JPA, JQuery, Sitemesh and more
http://www.manning.com/wannemacher
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Musachy Barroso <mu...@gmail.com>.
It has something to do with forking in the surefire plugin, running
the tests without forking works(for me at least):
mvn test -DforkMode=none
musachy
On Thu, Feb 26, 2009 at 2:38 AM, Lukasz Lenart
<lu...@googlemail.com> wrote:
> 2009/2/25 Lukasz Lenart <lu...@googlemail.com>:
>> Problems with testWildCardInclude and testFinder are related to new
>> Surefire plugin version, with 2.4 they fail, but passed with 2.3 (both
>> will pass under IDEA)
>
> I've been playing with testFinder but no idea what is wrong, when I
> launch it from command line the finder Vector is empty ;-(
>
>> testJaredFiles - is strange for me, there wasn't problem, but I will
>> double-check
>
> No clue, what is wrong, locally it works (from cmd and with IDEA), I'm
> using Maven 2.0.8, I will try to update to latest version and I will
> see
>
>> testOverflows - this can be related to conversion bug, but I will also
>> double-check
>
> I solved that problem, should be ok
>
>
> Regards
> --
> Lukasz
> http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Lukasz Lenart <lu...@googlemail.com>.
2009/2/25 Lukasz Lenart <lu...@googlemail.com>:
> Problems with testWildCardInclude and testFinder are related to new
> Surefire plugin version, with 2.4 they fail, but passed with 2.3 (both
> will pass under IDEA)
I've been playing with testFinder but no idea what is wrong, when I
launch it from command line the finder Vector is empty ;-(
> testJaredFiles - is strange for me, there wasn't problem, but I will
> double-check
No clue, what is wrong, locally it works (from cmd and with IDEA), I'm
using Maven 2.0.8, I will try to update to latest version and I will
see
> testOverflows - this can be related to conversion bug, but I will also
> double-check
I solved that problem, should be ok
Regards
--
Lukasz
http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: XWork test failures
Posted by Lukasz Lenart <lu...@googlemail.com>.
Problems with testWildCardInclude and testFinder are related to new
Surefire plugin version, with 2.4 they fail, but passed with 2.3 (both
will pass under IDEA)
testJaredFiles - is strange for me, there wasn't problem, but I will
double-check
testOverflows - this can be related to conversion bug, but I will also
double-check
Regards
--
Lukasz
http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org