You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/02 06:19:06 UTC

[GitHub] [shardingsphere] sandynz opened a new issue, #20730: Extract job configuration change event handler SPI and impl in PipelineJobExecutor for common usage

sandynz opened a new issue, #20730:
URL: https://github.com/apache/shardingsphere/issues/20730

   Part of #19421.
   
   Currently, it's hard-coded. It's better to extract job configuration change event handler SPI for common usage. SPI type could be JobType.typeName.
   
   Related code:
   - PipelineJobExecutor.processEvent method
   
   Possible changes:
   - Add SPI definition
   - Add SPI factory
   - Add SPI impl for migration job
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] azexcy commented on issue #20730: Extract job configuration change event handler SPI and impl in PipelineJobExecutor for common usage

Posted by GitBox <gi...@apache.org>.
azexcy commented on issue #20730:
URL: https://github.com/apache/shardingsphere/issues/20730#issuecomment-1235113457

   I will follow this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on issue #20730: Extract job configuration change event handler SPI and impl in PipelineJobExecutor for common usage

Posted by GitBox <gi...@apache.org>.
sandynz commented on issue #20730:
URL: https://github.com/apache/shardingsphere/issues/20730#issuecomment-1235112394

   @azexcy , could you help to follow it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] huangdx0726 commented on issue #20730: Extract job configuration change event handler SPI and impl in PipelineJobExecutor for common usage

Posted by GitBox <gi...@apache.org>.
huangdx0726 commented on issue #20730:
URL: https://github.com/apache/shardingsphere/issues/20730#issuecomment-1236243476

   Assign to me ，i will try


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on issue #20730: Extract job configuration change event handler SPI and impl in PipelineJobExecutor for common usage

Posted by GitBox <gi...@apache.org>.
sandynz commented on issue #20730:
URL: https://github.com/apache/shardingsphere/issues/20730#issuecomment-1238769853

   > Assign to me ，i will try
   
   Hi @huangdx0726 , there's PR on working. I'll create more issue later
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz closed issue #20730: Extract job configuration change event handler SPI and impl in PipelineJobExecutor for common usage

Posted by GitBox <gi...@apache.org>.
sandynz closed issue #20730: Extract job configuration change event handler SPI and impl in PipelineJobExecutor for common usage
URL: https://github.com/apache/shardingsphere/issues/20730


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org