You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/28 07:15:37 UTC

[GitHub] [flink] liyubin117 opened a new pull request, #21184: [FLINK-29787][ci] fix ci METHOD_NEW_DEFAULT issue

liyubin117 opened a new pull request, #21184:
URL: https://github.com/apache/flink/pull/21184

   ## What is the purpose of the change
   
   `org.apache.flink.api.connector.source.SourceReader` declared a new default function `pauseOrResumeSplits()`, japicmp plugin failed during ci running, we should configure the plugin to make it compatible.
   
   ## Brief change log
   
   * configure overrideCompatibilityChangeParameter
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] liyubin117 commented on pull request #21184: [FLINK-29787][ci] fix ci METHOD_NEW_DEFAULT issue

Posted by GitBox <gi...@apache.org>.
liyubin117 commented on PR #21184:
URL: https://github.com/apache/flink/pull/21184#issuecomment-1294696129

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] liyubin117 commented on pull request #21184: [FLINK-29787][ci] fix ci METHOD_NEW_DEFAULT issue

Posted by GitBox <gi...@apache.org>.
liyubin117 commented on PR #21184:
URL: https://github.com/apache/flink/pull/21184#issuecomment-1294645651

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] WencongLiu commented on pull request #21184: [FLINK-29787][ci] fix ci METHOD_NEW_DEFAULT issue

Posted by "WencongLiu (via GitHub)" <gi...@apache.org>.
WencongLiu commented on PR #21184:
URL: https://github.com/apache/flink/pull/21184#issuecomment-1700319487

   Hello @XComp @liyubin117 , currently I meet a same problem when I'm trying to add a new default method to a class with @Public annotation.  Should I just need to add an @PublicEvolving annotation to the new added default method to avoid this?
   
   BTW, according to the [API compatibility guarantees](https://nightlies.apache.org/flink/flink-docs-master/docs/ops/upgrading/)  in flink website, we shouldn't check binary incompatible between minor versions [flink/pom.xml](https://github.com/apache/flink/blob/aa8d93ea239f5be79066b7e5caad08d966c86ab2/pom.xml#L2246C5-L2246C5). We need to open a issue to fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] liyubin117 commented on pull request #21184: [FLINK-29787][ci] fix ci METHOD_NEW_DEFAULT issue

Posted by GitBox <gi...@apache.org>.
liyubin117 commented on PR #21184:
URL: https://github.com/apache/flink/pull/21184#issuecomment-1294741924

   @XComp Squash done. Thanks for your excellent idea :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #21184: [FLINK-29787][ci] fix ci METHOD_NEW_DEFAULT issue

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #21184:
URL: https://github.com/apache/flink/pull/21184#issuecomment-1700577328

   The default method covers the old implementation? That shouldn't be degraded to `@PublicEvolving`. :thinking:
   
   > BTW, according to the [API compatibility guarantees](https://nightlies.apache.org/flink/flink-docs-master/docs/ops/upgrading/) in flink website, we shouldn't check binary incompatible between minor versions [flink/pom.xml](https://github.com/apache/flink/blob/aa8d93ea239f5be79066b7e5caad08d966c86ab2/pom.xml#L2246C5-L2246C5). We need to open a issue to fix it.
   
   I created FLINK-33009 to cover this. Let's keep the discussion there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] liyubin117 commented on pull request #21184: [FLINK-29787][ci] fix ci METHOD_NEW_DEFAULT issue

Posted by GitBox <gi...@apache.org>.
liyubin117 commented on PR #21184:
URL: https://github.com/apache/flink/pull/21184#issuecomment-1294629597

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21184: [FLINK-29787][ci] fix ci METHOD_NEW_DEFAULT issue

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21184:
URL: https://github.com/apache/flink/pull/21184#issuecomment-1294578015

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a13759b2797cf038a61cb01e33d0bfbcacd9c2df",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a13759b2797cf038a61cb01e33d0bfbcacd9c2df",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a13759b2797cf038a61cb01e33d0bfbcacd9c2df UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #21184: [FLINK-29787][ci] fix ci METHOD_NEW_DEFAULT issue

Posted by GitBox <gi...@apache.org>.
XComp commented on PR #21184:
URL: https://github.com/apache/flink/pull/21184#issuecomment-1294747100

   The commits got a bit mixed up. I decided to squash everything into one because the documentation change should be reverted as well if the change itself was wrong. I merged the PR without waiting for CI to unblock `master`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp merged pull request #21184: [FLINK-29787][ci] fix ci METHOD_NEW_DEFAULT issue

Posted by GitBox <gi...@apache.org>.
XComp merged PR #21184:
URL: https://github.com/apache/flink/pull/21184


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp commented on pull request #21184: [FLINK-29787][ci] fix ci METHOD_NEW_DEFAULT issue

Posted by GitBox <gi...@apache.org>.
XComp commented on PR #21184:
URL: https://github.com/apache/flink/pull/21184#issuecomment-1294730181

   Thanks, @liyubin117 . Could you squash the commits into two? I would merge the PR then right away to unblock `master`. We can still revert this in case @HuangXingBo or somebody else objects this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] liyubin117 commented on pull request #21184: [FLINK-29787][ci] fix ci METHOD_NEW_DEFAULT issue

Posted by GitBox <gi...@apache.org>.
liyubin117 commented on PR #21184:
URL: https://github.com/apache/flink/pull/21184#issuecomment-1294709509

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] WencongLiu commented on pull request #21184: [FLINK-29787][ci] fix ci METHOD_NEW_DEFAULT issue

Posted by "WencongLiu (via GitHub)" <gi...@apache.org>.
WencongLiu commented on PR #21184:
URL: https://github.com/apache/flink/pull/21184#issuecomment-1700703681

   Thanks @XComp . 😄
   
   > The default method covers the old implementation? That shouldn't be degraded to @PublicEvolving.
   
   Apologies for any confusion caused. I just want to add a new default method to an existed @ Public **interface** that already have several old methods.  I think this behavior shouldn't break source compatible. I have reported this to **japicmp** community and the community owner replied that they will fix this in the next release. The [LINK](https://github.com/siom79/japicmp/issues/289) is here.
   
   > I think you're right. I created [FLINK-33009](https://issues.apache.org/jira/browse/FLINK-33009) to cover this. Let's keep the discussion there.
   
   I will discuss in FLINK-33009.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org