You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "featzhang (via GitHub)" <gi...@apache.org> on 2026/02/14 06:21:02 UTC

[PR] [table-planner] Enhance FlinkLogicalJoin explain output with structured condition display [flink]

featzhang opened a new pull request, #27610:
URL: https://github.com/apache/flink/pull/27610

   ## What is the purpose of the change
   
   This PR enhances the explain output of FlinkLogicalJoin to display join conditions in a more readable and structured format. Instead of showing low-level positional references like `=($0, $3)`, it now displays actual field names in a clear format.
   
   **Before:**
   ```
   Join(condition=[=($0, $3)])
   ```
   
   **After:**
   ```
   Join:
     Type: INNER
     Condition: user_id = id
   ```
   
   ## Brief change log
   
   - Add `explainTerms` override method in FlinkLogicalJoin class
   - Implement `formatJoinCondition` method for recursive RexNode condition parsing
   - Implement `formatOperand` method for field reference resolution
   - Support for EQUALS, AND, OR operators with proper field name resolution
   - Use FlinkRexUtil.getExpressionString as fallback for complex expressions
   
   ## Verifying this change
   
   This change is a display-only enhancement and can be verified by:
   
   1. Build the flink-table-planner module:
      ```bash
      ./mvnw clean install -DskipTests -Pfast -pl flink-table/flink-table-planner
      ```
   
   2. Run EXPLAIN queries in Flink SQL Client with joins:
      ```sql
      EXPLAIN SELECT * FROM orders o JOIN users u ON o.user_id = u.id;
      ```
   
   3. Verify the join condition is displayed with field names instead of positional references
   
   ## Does this pull request potentially affect one of the following parts:
   
   - Dependencies (does it add or upgrade a dependency): **No**
   - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **No**
   - The serializers: **No**
   - The runtime per-record code paths (performance sensitive): **No**
   - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **No**
   - The S3 file system connector: **No**
   
   ## Documentation
   
   - Does this pull request introduce a new feature? **No** (Enhancement only)
   - If yes, how is the feature documented? **Not applicable**
   
   This change only enhances the explain output format and does not modify any RelNode structure, query optimization logic, or runtime behavior. It has zero impact on performance and is 100% backward compatible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-39090][SQL] Enhance structured condition display of Explain output [flink]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27610:
URL: https://github.com/apache/flink/pull/27610#issuecomment-4999959149

   This PR has been closed since it has not had any activity in 120 days. 
   If you feel like this was a mistake, or you would like to continue working on it, 
   please feel free to re-open the PR and ask for a review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-39090][SQL] Enhance structured condition display of Explain output [flink]

Posted by "featzhang (via GitHub)" <gi...@apache.org>.
featzhang commented on PR #27610:
URL: https://github.com/apache/flink/pull/27610#issuecomment-3995071890

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-39090][SQL] Enhance structured condition display of Explain output [flink]

Posted by "featzhang (via GitHub)" <gi...@apache.org>.
featzhang commented on PR #27610:
URL: https://github.com/apache/flink/pull/27610#issuecomment-4064452877

   This PR is being closed due to CI failures. Please fix the issues and reopen when ready.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-39090][SQL] Enhance structured condition display of Explain output [flink]

Posted by "featzhang (via GitHub)" <gi...@apache.org>.
featzhang closed pull request #27610: [FLINK-39090][SQL] Enhance structured condition display of Explain output
URL: https://github.com/apache/flink/pull/27610


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [table-planner] Enhance FlinkLogicalJoin explain output with structured condition display [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #27610:
URL: https://github.com/apache/flink/pull/27610#issuecomment-3901240065

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "bae6bd67498510bae190403edd4a942519c9da46",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "bae6bd67498510bae190403edd4a942519c9da46",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bae6bd67498510bae190403edd4a942519c9da46 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-39090][SQL] Enhance structured condition display of Explain output [flink]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #27610: [FLINK-39090][SQL] Enhance structured condition display of Explain output
URL: https://github.com/apache/flink/pull/27610


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-39090][SQL] Enhance structured condition display of Explain output [flink]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27610:
URL: https://github.com/apache/flink/pull/27610#issuecomment-4716426150

   This PR is being marked as stale since it has not had any activity in the last 90 days. 
   If you would like to keep this PR alive, please leave a comment asking for a review. 
   If the PR has merge conflicts, update it with the latest from the base branch.
   
   If you are having difficulty finding a reviewer, please reach out to the 
   community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
   
   If this PR is no longer valid or desired, please feel free to close it. 
   If no activity occurs in the next 30 days, it will be automatically closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org