You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/03/06 00:27:57 UTC
Re: Review Request 65590: Added helper function to determine provider
ID of a conversion.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65590/#review198668
-----------------------------------------------------------
Fix it, then Ship it!
src/common/resources_utils.cpp
Lines 295 (patched)
<https://reviews.apache.org/r/65590/#comment278912>
Do we need the underscore here?
- Greg Mann
On Feb. 14, 2018, 3:11 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65590/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2018, 3:11 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-8382
> https://issues.apache.org/jira/browse/MESOS-8382
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added helper function to determine provider ID of a conversion.
>
>
> Diffs
> -----
>
> src/common/resources_utils.hpp 73d070d48eedf30468305e96fc4ad0005584fc79
> src/common/resources_utils.cpp 99b16e0d17b224eefa1e28f5f66c4284069c0e57
>
>
> Diff: https://reviews.apache.org/r/65590/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>