You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/11 17:33:00 UTC
[jira] [Commented] (CB-13006) Move e2e create tests to unit tests
[ https://issues.apache.org/jira/browse/CB-13006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082611#comment-16082611 ]
ASF GitHub Bot commented on CB-13006:
-------------------------------------
GitHub user filmaj opened a pull request:
https://github.com/apache/cordova-android/pull/394
CB-13006: replace create end-to-end tests with unit tests
There were create end-to-end tests that validated use of unicode, spaces and ascii characters in project names and destination paths. These tests were HEAVY - they would shell out to create _and_ compile each one, and there were 6 of these tests. Additionally, these tests would regularly time out on Travis.
Instead, this PR replaces those tests with lighter weight unit tests exercising the same logic (hopefully).
*NOTE*: by removing the create end-to-end tests, we now no longer test that created projects can compile using the Android SDK. We may want to consider adding a basic smoke-test for this back into the end-to-end tests.
Please review / discuss / FYI @infil00p, @stevengill, @dpogue, @alsorokin, @matrosov-nikita, @jcesarmobile
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/filmaj/cordova-android CB-13006
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/394.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #394
----
commit 41c24a8ae1f3415d3fc0bdc6f6fd00fa7075a15a
Author: filmaj <ma...@gmail.com>
Date: 2017-07-11T17:25:12Z
CB-13006: removed create end-to-end tests, and instead added more unit test coverage. tweaked code coverage invocation so that we get coverage details on the create.js module. slight changes to the create.js module so that it is slightly easier to test.
----
> Move e2e create tests to unit tests
> -----------------------------------
>
> Key: CB-13006
> URL: https://issues.apache.org/jira/browse/CB-13006
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Reporter: Filip Maj
> Assignee: Filip Maj
>
> Instead of having these tests shell out to create (and also compile!) the cordova-android project, we should write up unit tests to ensure that the functionality the tests are trying to cover (support for ascii/unicode/spaces in project names).
> This would really speed up our testing.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org