[GitHub] [mesos] qianzhangxa commented on a change in pull request #422: FIX: mesos rpm add command and change mesos_isolation.

[GitBox <gi...@apache.org>]

qianzhangxa commented on a change in pull request #422:
URL: https://github.com/apache/mesos/pull/422#discussion_r839369156



##########
File path: support/mesos-mini/mesos/agent_environment
##########
@@ -3,7 +3,7 @@ MESOS_HOSTNAME=localhost
 MESOS_WORK_DIR=/var/lib/mesos/agent
 MESOS_MASTER=127.0.0.1:5050
 MESOS_CONTAINERIZERS=mesos,docker
-MESOS_ISOLATION=filesystem/linux,network/cni,cgroups/cpu,cgroups/mem,cgroups/blkio,cgroups/devices,disk/du,docker/runtime,volume/sandbox_path,volume/host_path,posix/rlimits,namespaces/pid,linux/capabilities

Review comment:
       So it is the `linux/capabilities` isolator causes Mesos agent cannot start, can you please paste the error log here? I'd like to know why agent fails to start.

##########
File path: support/packaging/centos/build-docker-centos.sh
##########
@@ -24,7 +24,7 @@ DOCKER_CONTEXT_DIR="${SOURCE_DIR}/centos${CENTOS_DISTRO}/rpmbuild/RPMS/x86_64"
 
 cat <<EOF > "${DOCKER_CONTEXT_DIR}/Dockerfile"
 FROM centos:${CENTOS_DISTRO}
-ADD mesos-?.?.?-*.rpm /

Review comment:
       Can you please elaborate a bit on why `?.?.?` does not work?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org