You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Ben Hyde <bh...@gensym.com> on 1998/03/18 19:34:47 UTC

[PATCH] Don't encourage sloppy configuring.

Oh the poor innocent soul typed:
   > ./Configure --help
   Ignoring command line option '--help'
   Using config file: Configuration
   Creating Makefile
   ...
Ouch.

Now it does:
   > ./Configure --help
   ERROR: Bad command line option '--help'
     Please read the file INSTALL.
   >

---
> cvs diff -u Configure
Index: Configure
===================================================================
RCS file: /cvs/apache-1.3/src/Configure,v
retrieving revision 1.212
diff -u -r1.212 Configure
--- Configure	1998/03/17 16:08:44	1.212
+++ Configure	1998/03/18 18:27:55
@@ -101,8 +101,9 @@
       exit 1
     fi
   else
-    echo "Ignoring command line option '$1'"
-    shift 1
+    echo "ERROR: Bad command line option '$1'"
+    echo "  Please read the file INSTALL."
+    exit 1
   fi
 done
 if [ ! -r $file ]; then

Re: [PATCH] Don't encourage sloppy configuring.

Posted by Martin Kraemer <Ma...@mch.sni.de>.
On Wed, Mar 18, 1998 at 01:34:47PM -0400, Ben Hyde wrote:
> Oh the poor innocent soul typed:
>    > ./Configure --help
>    Ignoring command line option '--help'
>    Using config file: Configuration
>    Creating Makefile
>    ...
> Ouch.

Yup. +1 for your solution. ``Do it right -- or don't do it at all''

    Martin
-- 
| S I E M E N S |  <Ma...@mch.sni.de>  |      Siemens Nixdorf
| ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
| N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request