You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/10/05 07:19:59 UTC
[GitHub] [orc] guiyanakuang opened a new pull request #930: ORC-1019: Remove redundant jackson dependencies
guiyanakuang opened a new pull request #930:
URL: https://github.com/apache/orc/pull/930
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of describing the problem.
3. Make PR title and description complete because these will be the permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
This PR aims to remove redundant jackson dependencies.
Unfortunately, ORC-946 forgot to remove the bench dependency on jackson. In fact, the bench module does not directly depend on jackson, only spark indirectly depends on the specified version of jackson.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Minimising dependencies.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Pass the CIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun edited a comment on pull request #930: ORC-1019: Remove redundant jackson dependencies
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #930:
URL: https://github.com/apache/orc/pull/930#issuecomment-936888466
Merged to `main` for Apache ORC 1.8.
BTW, one tip for you, @guiyanakuang .
When we override another PR, you can use `Closes #928` at the bottom of PR description.
It will close that specific PR when this PR get merged.
For this PR, I revised the PR description and merged it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang edited a comment on pull request #930: ORC-1019: Remove redundant jackson dependencies
Posted by GitBox <gi...@apache.org>.
guiyanakuang edited a comment on pull request #930:
URL: https://github.com/apache/orc/pull/930#issuecomment-935312527
> Thank you for making a PR, @guiyanakuang . BTW, this looks like a revert of [ORC-807](https://issues.apache.org/jira/browse/ORC-807) (from @belugabehr )
>
> So, is this the current status, @guiyanakuang ?
>
> > In fact, the bench module does not directly depend on jackson, only spark indirectly depends on the specified version of jackson.
Yes, because the code that depends on jackson has been rewritten with gson in ORC-946. I'm sure this is the current state.
> Comment before update: which reminds me that we don't even need to declare Spark's dependency on jackson, there is no conflict.
> I immediately made a new commit to remove the explicit dependency of spark on jackson.
update: I was wrong, actually spark and avro depend on different versions of jackson in orc-benchmarks-spark, explicit dependencies are better than letting maven choose based on the length of the dependency path, I think it's better to keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang edited a comment on pull request #930: ORC-1019: Remove redundant jackson dependencies
Posted by GitBox <gi...@apache.org>.
guiyanakuang edited a comment on pull request #930:
URL: https://github.com/apache/orc/pull/930#issuecomment-935312527
> Thank you for making a PR, @guiyanakuang . BTW, this looks like a revert of [ORC-807](https://issues.apache.org/jira/browse/ORC-807) (from @belugabehr )
>
> So, is this the current status, @guiyanakuang ?
>
> > In fact, the bench module does not directly depend on jackson, only spark indirectly depends on the specified version of jackson.
Yes, because the code that depends on jackson has been rewritten with gson in ORC-946. I'm sure this is the current state.
> Comment before update: which reminds me that we don't even need to declare Spark's dependency on jackson, there is no conflict.
> I immediately made a new commit to remove the explicit dependency of spark on jackson.
update: I was wrong, actually spark and avro depend on different versions of jackson, explicit dependencies are better than letting maven choose based on the length of the dependency path, I think it's better to keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #930: ORC-1019: Remove redundant jackson dependencies
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #930:
URL: https://github.com/apache/orc/pull/930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #930: ORC-1019: Remove redundant jackson dependencies
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #930:
URL: https://github.com/apache/orc/pull/930#issuecomment-936888466
Merged to `main` for Apache ORC 1.8.
BTW, one tip for you, @guiyanakuang .
When we override another PR, you can use `Closes #928` at the bottom of PR description.
It will close that specific PR when this PR get merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #930: ORC-1019: Remove redundant jackson dependencies
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #930:
URL: https://github.com/apache/orc/pull/930#issuecomment-937331111
> Merged to `main` for Apache ORC 1.8.
>
> BTW, one tip for you, @guiyanakuang . When we override another PR, you can use `Closes #928` at the bottom of PR description. It will close that specific PR when this PR get merged.
>
> For this PR, I revised the PR description and merged it.
Got it, hahaha, thank you @dongjoon-hyun .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #930: ORC-1019: Remove redundant jackson dependencies
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #930:
URL: https://github.com/apache/orc/pull/930#issuecomment-936883010
Got it, @guiyanakuang !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #930: ORC-1019: Remove redundant jackson dependencies
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #930:
URL: https://github.com/apache/orc/pull/930#issuecomment-935346767
Ya, I agree with your updated opinion, @guiyanakuang . Then, shall we close this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #930: ORC-1019: Remove redundant jackson dependencies
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #930:
URL: https://github.com/apache/orc/pull/930#issuecomment-935347743
Since you investigated this, please take over https://github.com/apache/orc/pull/928.
If you make a PR, I will merge yours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #930: ORC-1019: Remove redundant jackson dependencies
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #930:
URL: https://github.com/apache/orc/pull/930#issuecomment-935388465
@dongjoon-hyun. Sorry, I didn't make my point clearly.
My updated view is to keep the orc-benchmarks-spark dependency unchanged, but we can remove the jackson dependency from the overall definition of the bench, as we don't explicitly use jakcson in the bench anymore, and the previous part in orc-benchmarks-core was already rewritten using gson rewrites the So my view is to use this pr instead of bot. This pr still retains the explicit specification of jackson by orc-benchmarks-spark. 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun edited a comment on pull request #930: ORC-1019: Remove redundant jackson dependencies
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #930:
URL: https://github.com/apache/orc/pull/930#issuecomment-935347743
Since you investigated this, please take over https://github.com/apache/orc/pull/928.
If you make a PR, I will merge yours.
The bot is only reducing the human-labor to check the new versions. So, the main contribution is the human review and investigation. Thank you for your review on https://github.com/apache/orc/pull/928 and investigation on this. I really appreciate your passion and contribution, @guiyanakuang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #930: ORC-1019: Remove redundant jackson dependencies
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #930:
URL: https://github.com/apache/orc/pull/930#issuecomment-935312527
> Thank you for making a PR, @guiyanakuang . BTW, this looks like a revert of [ORC-807](https://issues.apache.org/jira/browse/ORC-807) (from @belugabehr )
>
> So, is this the current status, @guiyanakuang ?
>
> > In fact, the bench module does not directly depend on jackson, only spark indirectly depends on the specified version of jackson.
Yes, because the code that depends on jackson has been rewritten with gson in ORC-946, which reminds me that we don't even need to declare Spark's dependency on jackson, there is no conflict.
I immediately made a new commit to remove the explicit dependency of spark on jackson.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on pull request #930: ORC-1019: Remove redundant jackson dependencies
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on pull request #930:
URL: https://github.com/apache/orc/pull/930#issuecomment-937331111
> Merged to `main` for Apache ORC 1.8.
>
> BTW, one tip for you, @guiyanakuang . When we override another PR, you can use `Closes #928` at the bottom of PR description. It will close that specific PR when this PR get merged.
>
> For this PR, I revised the PR description and merged it.
Got it, hahaha, thank you @dongjoon-hyun .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org