[GitHub] [groovy] eric-milles commented on a change in pull request #1303: GROOVY-7996: STC: error for mismatched closure resolve strategies

[GitBox <gi...@apache.org>]

eric-milles commented on a change in pull request #1303:
URL: https://github.com/apache/groovy/pull/1303#discussion_r452412460



##########
File path: src/test/org/codehaus/groovy/classgen/asm/sc/DelegatesToStaticCompileTest.groovy
##########
@@ -111,4 +111,29 @@ class DelegatesToStaticCompileTest extends DelegatesToSTCTest implements StaticC
             assert !bytecode.contains('INVOKESTATIC org/codehaus/groovy/runtime/ScriptBytecodeAdapter.castToType')
         }
     }
-}
\ No newline at end of file
+
+    // GROOVY-7996
+    void testErrorForMismatchedClosureResolveStrategy() {
+        shouldFailWithMessages '''
+            class Foo {
+                def build(Closure x) { // resolve strategy OWNER_FIRST
+                    this.with(x) // resolve strategy DELEGATE_FIRST
+                }
+                def propertyMissing(String name) {
+                    'something'
+                }
+            }
+
+            class Bar {
+                protected List bars = []
+                def baz() {
+                    new Foo().build {
+                        bars.isEmpty() // fails if executed; delegate's propertyMissing takes precedence
+                    }
+                }
+            }
+
+            new Bar().baz()
+        ''', 'Closure parameter with resolve strategy 0 passed to method with resolve strategy 1'

Review comment:
       Added method to ClosureUtils and moved the test so it is tried for `@CompileStatic` and `@TypeChecked`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org