[GitHub] [incubator-hudi] umehrot2 commented on a change in pull request #957: [HUDI-268] Provide mechanism to shade and relocate Avro dependency in hadoop-mr-bundle

[GitBox <gi...@apache.org>]

umehrot2 commented on a change in pull request #957: [HUDI-268] Provide mechanism to shade and relocate Avro dependency in hadoop-mr-bundle
URL: https://github.com/apache/incubator-hudi/pull/957#discussion_r335146333
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -100,6 +100,8 @@
     <skipUTs>${skipTests}</skipUTs>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     <main.basedir>${project.basedir}</main.basedir>
+    <mr.bundle.avro.scope>provided</mr.bundle.avro.scope>
 
 Review comment:
   Unfortunately yes. If we move it to bundle POM, then `aws-emr-profile` does not work, and only `mr-bundle-shade-avro` works.
   
   Maven possibly looks for the property to be present in the same pom file or atleast be inherited from its parent in order to override it using Profiles.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services