You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "zhangjun0x01 (via GitHub)" <gi...@apache.org> on 2023/08/23 14:46:21 UTC
[GitHub] [incubator-paimon] zhangjun0x01 opened a new pull request, #1877: [flink] add table comment for create table in sync action
zhangjun0x01 opened a new pull request, #1877:
URL: https://github.com/apache/incubator-paimon/pull/1877
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
in flink sync action , sync the table comment when create new table.
<!-- What is the purpose of the change -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #1877: [flink] add table comment for create table in sync action
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #1877:
URL: https://github.com/apache/incubator-paimon/pull/1877#discussion_r1306934196
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/cdc/mysql/MySqlActionUtils.java:
##########
@@ -79,13 +79,13 @@ static Connection getConnection(Configuration mySqlConfig, boolean tinyint1NotBo
throws Exception {
String url =
String.format(
- "jdbc:mysql://%s:%d%s",
+ "jdbc:mysql://%s:%d?useInformationSchema=true%s",
Review Comment:
Default auto?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] add table comment for create table in sync action [paimon]
Posted by "zhuangchong (via GitHub)" <gi...@apache.org>.
zhuangchong closed pull request #1877: [flink] add table comment for create table in sync action
URL: https://github.com/apache/paimon/pull/1877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] zhangjun0x01 commented on a diff in pull request #1877: [flink] add table comment for create table in sync action
Posted by "zhangjun0x01 (via GitHub)" <gi...@apache.org>.
zhangjun0x01 commented on code in PR #1877:
URL: https://github.com/apache/incubator-paimon/pull/1877#discussion_r1306886240
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/cdc/mysql/MySqlActionUtils.java:
##########
@@ -79,13 +79,13 @@ static Connection getConnection(Configuration mySqlConfig, boolean tinyint1NotBo
throws Exception {
String url =
String.format(
- "jdbc:mysql://%s:%d%s",
+ "jdbc:mysql://%s:%d?useInformationSchema=true%s",
Review Comment:
the param in default `true` in mysql 8.0.3 ([doc](https://dev.mysql.com/doc/connector-j/8.1/en/connector-j-connp-props-metadata.html)) ,but it is default `false` in mysql 5.7, if we add an option and when we set it to `false` ,do we should set it to `false` explicitly in mysql8 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #1877: [flink] add table comment for create table in sync action
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #1877:
URL: https://github.com/apache/incubator-paimon/pull/1877#discussion_r1306934483
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/cdc/mysql/MySqlActionUtils.java:
##########
@@ -79,13 +79,13 @@ static Connection getConnection(Configuration mySqlConfig, boolean tinyint1NotBo
throws Exception {
String url =
String.format(
- "jdbc:mysql://%s:%d%s",
+ "jdbc:mysql://%s:%d?useInformationSchema=true%s",
Review Comment:
Or default we can just disable table comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #1877: [flink] add table comment for create table in sync action
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #1877:
URL: https://github.com/apache/incubator-paimon/pull/1877#discussion_r1306861375
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/cdc/mysql/MySqlActionUtils.java:
##########
@@ -79,13 +79,13 @@ static Connection getConnection(Configuration mySqlConfig, boolean tinyint1NotBo
throws Exception {
String url =
String.format(
- "jdbc:mysql://%s:%d%s",
+ "jdbc:mysql://%s:%d?useInformationSchema=true%s",
Review Comment:
Should we use an option to open this feature?
I don't know how much impact it has in performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] add table comment for create table in sync action [paimon]
Posted by "zhuangchong (via GitHub)" <gi...@apache.org>.
zhuangchong commented on PR #1877:
URL: https://github.com/apache/paimon/pull/1877#issuecomment-2225325339
Already supported, I will close this PR first. If you have any questions, you can open it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org