You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/05/09 07:22:52 UTC

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9013: VM monitoring adapt the latest version `0.50.0`of the `opentelemetry-collector`

wu-sheng commented on code in PR #9013:
URL: https://github.com/apache/skywalking/pull/9013#discussion_r867707345


##########
oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/oc/OCMetricHandler.java:
##########
@@ -54,14 +55,15 @@
 
 @Slf4j
 public class OCMetricHandler extends MetricsServiceGrpc.MetricsServiceImplBase implements Handler {
-
+    public static final String HOST_NAME_LABEL = "node_identifier_host_name";

Review Comment:
   ```suggestion
       private static final String HOST_NAME_LABEL = "node_identifier_host_name";
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org