[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a change in pull request #51: [FLINK-26572] Improve reconcile reschedule configs and defaults

[GitBox <gi...@apache.org>]

wangyang0918 commented on a change in pull request #51:
URL: https://github.com/apache/flink-kubernetes-operator/pull/51#discussion_r824359419



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkOperatorConfiguration.java
##########
@@ -26,26 +26,33 @@
 @Value
 public class FlinkOperatorConfiguration {
 
-    int reconcileIntervalInSec;
-
-    int portCheckIntervalInSec;
-
-    int savepointTriggerGracePeriodInSec;
+    int reconcileIntervalSeconds;
+    int progressCheckIntervalSeconds;
+    int restApiReadyDelaySeconds;
+    int savepointTriggerGracePeriodSeconds;
 
     public static FlinkOperatorConfiguration fromConfiguration(Configuration operatorConfig) {
-        int reconcileIntervalInSec =
+        int reconcileIntervalSeconds =
                 operatorConfig.getInteger(
                         OperatorConfigOptions.OPERATOR_RECONCILER_RESCHEDULE_INTERVAL_IN_SEC);
-        int portCheckIntervalInSec =
+
+        int restApiReadyDelaySeconds =

Review comment:
       Out the scope of this PR.
   
   To be honest, I do not like the `restApiReadyDelaySeconds` configuration. This make the `JobManagerDeploymentStatus.READY` not really ready for accepting REST API calls. This will be problem if we are running session cluster.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org