You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org> on 2016/06/02 09:28:59 UTC
[jira] [Updated] (HBASE-15174) Client Public API should not have PB
objects in 2.0
[ https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-15174:
-------------------------------------------
Attachment: HBASE-15174.patch
This is the UT and I added some completeness to it by adding assertions and splitting it into 2 UTs. Currently this test fails because of ServerLoad#obtainServerLoadPB. RemoteWithExtrasException extends hadoop protobuf RemoteException, as we are searching for hbase protobuf only this class does not come into the list. If not even that can be considered as a public API returning a protobuf class.
> Client Public API should not have PB objects in 2.0
> ---------------------------------------------------
>
> Key: HBASE-15174
> URL: https://issues.apache.org/jira/browse/HBASE-15174
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-15174.patch
>
>
> Some more cleanup for the parent jira.
> We have leaked some PB structs in Admin (and possible other places).
> We should clean up these API before 2.0.
> Examples include:
> {code}
> AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final TableName tableName)
> throws IOException;
>
> ....
> void snapshot(final String snapshotName,
> final TableName tableName,
> HBaseProtos.SnapshotDescription.Type type) throws IOException, SnapshotCreationException,
> IllegalArgumentException;
> ....
> MasterProtos.SnapshotResponse takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
> throws IOException, SnapshotCreationException;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)