[GitHub] [hadoop] tasanuma commented on a change in pull request #3843: HDFS-16400. Reconfig DataXceiver parameters for datanode

[GitBox <gi...@apache.org>]

tasanuma commented on a change in pull request #3843:
URL: https://github.com/apache/hadoop/pull/3843#discussion_r782022532



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
##########
@@ -647,13 +650,37 @@ public String reconfigurePropertyImpl(String property, String newVal)
       }
       break;
     }
+    case DFS_DATANODE_MAX_RECEIVER_THREADS_KEY:
+      return reconfDataXceiverParameters(property, newVal);
     default:
       break;
     }
     throw new ReconfigurationException(
         property, newVal, getConf().get(property));
   }
 
+  private String reconfDataXceiverParameters(String property, String newVal)
+      throws ReconfigurationException {
+    String result;
+    try {
+      LOG.info("Reconfiguring {} to {}", property, newVal);
+      if (property.equals(DFS_DATANODE_MAX_RECEIVER_THREADS_KEY)) {

Review comment:
       The if-statement seems redundant since it is already checked by `case DFS_DATANODE_MAX_RECEIVER_THREADS_KEY `.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org