You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by "muyangye (via GitHub)" <gi...@apache.org> on 2023/11/05 04:58:18 UTC
[PR] [#1936] Adapter Deletion: Disallow Deletion of Pipelines Using Adapter but Not Owned by User
muyangye opened a new pull request, #2139:
URL: https://github.com/apache/streampipes/pull/2139
<!--
~ Licensed to the Apache Software Foundation (ASF) under one or more
~ contributor license agreements. See the NOTICE file distributed with
~ this work for additional information regarding copyright ownership.
~ The ASF licenses this file to You under the Apache License, Version 2.0
~ (the "License"); you may not use this file except in compliance with
~ the License. You may obtain a copy of the License at
~
~ http://www.apache.org/licenses/LICENSE-2.0
~
~ Unless required by applicable law or agreed to in writing, software
~ distributed under the License is distributed on an "AS IS" BASIS,
~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
~ See the License for the specific language governing permissions and
~ limitations under the License.
~
-->
<!--
Thanks for contributing! Here are some tips you can follow to help us incorporate your contribution quickly and easily:
1. If this is your first time, please read our contributor guidelines:
- https://streampipes.apache.org/getinvolved.html
- https://cwiki.apache.org/confluence/display/STREAMPIPES/Getting+Started
2. Make sure the PR title is formatted like: `[#<GitHub issue id>] PR title ...`
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., `[WIP][#<GitHub issue id>] PR title ...`.
4. Please write your PR title to summarize what this PR proposes/fixes.
5. Link the PR to the corresponding GitHub issue (if present) in the `Development` section in the right menu bar.
6. Be sure to keep the PR description updated to reflect all changes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
8. Make sure tests pass via `mvn clean install`.
9. (Optional) If the contribution is large, please file an Apache ICLA
- http://apache.org/licenses/icla.pdf
-->
### Purpose
<!--
Please clarify what changes you are proposing and describe how those changes will address the issue.
Furthermore, describe potential consequences the changes might have.
-->
See #1936
### Remarks
<!--
Is there anything left we need to pay attention on?
Are there some references that might be important? E.g. links to Confluence, or discussions
on the mailing list or GitHub.
-->
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1936] Adapter Deletion: Disallow Deletion of Pipelines Using Adapter but Not Owned by User
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe merged PR #2139:
URL: https://github.com/apache/streampipes/pull/2139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1936] Adapter Deletion: Disallow Deletion of Pipelines Using Adapter but Not Owned by User
Posted by "dominikriemer (via GitHub)" <gi...@apache.org>.
dominikriemer commented on PR #2139:
URL: https://github.com/apache/streampipes/pull/2139#issuecomment-1796373893
Hi @muyangye great that you're working on this topic!
Yes, I think admin users should always be able to delete resources owned by others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1936] Adapter Deletion: Disallow Deletion of Pipelines Using Adapter but Not Owned by User
Posted by "muyangye (via GitHub)" <gi...@apache.org>.
muyangye commented on PR #2139:
URL: https://github.com/apache/streampipes/pull/2139#issuecomment-1796434705
> Hi @muyangye great that you're working on this topic!
> Yes, I think admin users should always be able to delete resources owned by others.
Can they also delete resources owned by another admin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1936] Adapter Deletion: Disallow Deletion of Pipelines Using Adapter but Not Owned by User
Posted by "muyangye (via GitHub)" <gi...@apache.org>.
muyangye commented on PR #2139:
URL: https://github.com/apache/streampipes/pull/2139#issuecomment-1793637868
Currently, even admin can't delete pipelines created by others because I am comparing the id of pipeline's owner with the id of the user. Let me know if admin should delete pipelines not owned by himself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1936] Adapter Deletion: Disallow Deletion of Pipelines Using Adapter but Not Owned by User
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe commented on PR #2139:
URL: https://github.com/apache/streampipes/pull/2139#issuecomment-1797896275
Hello @muyangye,
thanks for your work on this topic.
In my opinion, it makes perfect sense for an admin to have the right to delete all resources, even if they were created by another admin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#1936] Adapter Deletion: Disallow Deletion of Pipelines Using Adapter but Not Owned by User
Posted by "muyangye (via GitHub)" <gi...@apache.org>.
muyangye commented on PR #2139:
URL: https://github.com/apache/streampipes/pull/2139#issuecomment-1798080943
@dominikriemer @tenthe, thanks for clarifying! Just pushed an update that addressed this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org