[GitHub] [trafficcontrol] moltzaum opened a new pull request #3523: Source the X509_CA_ENV_FILE in trafficops

[GitBox <gi...@apache.org>]

moltzaum opened a new pull request #3523: Source the X509_CA_ENV_FILE in trafficops
URL: https://github.com/apache/trafficcontrol/pull/3523
 
 
   
   ## What does this PR (Pull Request) do?
   
   When I start up my TO container with trafficvault, the ssl keys aren't added correctly because the environment variables aren't sourced. Every other run file sources the env variables correctly, so I'm using them as a reference.
   
   ## Which Traffic Control components are affected by this PR?
   <!-- Please delete all components from this list that are NOT affected by this
   Pull Request. Also, feel free to add the name of a tool or script that is
   affected but not on the list.
   
   Additionally, if this Pull Request does NOT affect documentation, please
   explain why documentation is not required. -->
   
   - CDN in a Box
   
   ## What is the best way to verify this PR?
   
   `rm -rf trafficops/ca`
   Make sure volumes are removed by checking `docker volume ls`
   `docker-compose build trafficops`
   `variables.env:96: AUTO_SNAPQUEUE_ENABLED=false`
   `docker-compose up -d trafficops trafficvault`
   `docker-compose logs -f trafficops`
   
   The trafficops logs should output `exec tail -f /dev/null` and stop. If the logs loop forever it didn't start up correctly.
   I am running a limited stack, but running the whole stack should also work the same.
   
   ## If this is a bug fix, what versions of Traffic Ops are affected?
   <!-- If this PR fixes a bug, please list here all of the affected versions - to
   the best of your knowledge. It's also pretty helpful to include a commit hash
   of where 'master' is at the time this PR is opened (if it affects master),
   because what 'master' means will change over time. For example, if this PR
   fixes a bug that's present in master (at commit hash '2697ebac'), in v3.0.0,
   and in the current 3.0.1 Release candidate (e.g. RC1), then this list would
   look like:
   
   - master (2697ebac)
   - 3.0.0
   - 3.0.1 (RC1)
   
   If you don't know what other versions might have this bug, AND don't know how
   to find the commit hash of 'master', then feel free to leave this section
   blank (or, preferably, delete it entirely).
    -->
   
   
   ## The following criteria are ALL met by this PR
   <!-- Check the boxes to signify that the associated statement is true. To
   "check a box", replace the space inside of the square brackets with an 'x'.
   e.g.
   
   - [ x] <- Wrong
   - [x ] <- Wrong
   - [] <- Wrong
   - [*] <- Wrong
   - [x] <- Correct!
   
   -->
   
   - [x] This PR includes tests OR I have explained why tests are unnecessary
       - I am doing what the other run files are doing, which should be sufficient. There isn't a "test" per-se, but there is a conditional to test if the env var was set.
   - [x] Documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services