You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by Havret <ha...@apache.org> on 2022/05/09 20:35:24 UTC
[VOTE] Release activemq-nms-api 1.8.1-rc2
Hi all,
I have put together a release of activemq-nms-api, please check it
and vote accordingly.
This release contains a single bugfix[1] by Iuliia Fatkullina! Thank you!
Besides that I cherry-picked notice and license updates from the master
branch[2].
The files can be grabbed from:
https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-api/1.8.1-rc2/
Regards,
Krzysztof
[1]: https://issues.apache.org/jira/browse/AMQNET-745
[2]:
https://github.com/apache/activemq-nms-api/commit/b837a87307aaca798b7ef6c2436d4d25b3f65c72
Re: [VOTE] Release activemq-nms-api 1.8.1-rc2
Posted by Robbie Gemmell <ro...@gmail.com>.
I see. Presumably the '?' at the end is making Windows barf on the
file, whereas its fine on the other OS folks are using to work on
them. I vaguely recalled there was some javadoc files a few years back
that were doing similar, I removed those but didnt know of these ones:
https://lists.apache.org/thread/h69d93ls3vwgf695wszty2lbmcclfzpc
No other release content has these particular '?<etc>' named files
besides 1.5.0 and 2.7.0. The same-base-named files also exist without
the suffixes though, just as they do in all the other releases.
Perhaps a bug in the particular generator used when publishing those
releases. I deleted these 'extra' files locally and couldn't discern
any issues in trying the docs out, plus decided that as they are
pretty/very old releases now it doesnt especially matter anyway if we
did affect their display in some way at this point.
Deleted and pushed, so you can try again now.
Some of these files appear to have been there for ~6 years. It's very
unlikely those who dont develop on Windows will ever spot such things,
especially if those that want to aren't fixing or noting them across
such vast timeframes.
Robbie
On Thu, 9 Jun 2022 at 20:55, Havret <h4...@gmail.com> wrote:
>
> Sorry Robbie, I missed your email. I've already announced the release.
>
> The problem I'm having with the activemq website on windows is that I
> cannot even clone the repository. Every time I try to fetch it, I'm
> getting the following error:
>
> error: invalid path
> 'src/components/artemis/documentation/1.5.0/gitbook/fonts/fontawesome/fontawesome-webfont.eot?'
> fatal: unable to checkout working tree
> warning: Clone succeeded, but checkout failed.
> You can inspect what was checked out with 'git status'
> and retry with 'git restore --source=HEAD :/'
>
> It works fine on MacOS though.
>
> Thanks,
> Krzysztof
>
> On Mon, Jun 6, 2022 at 4:50 PM Robbie Gemmell <ro...@gmail.com>
> wrote:
>
> > Since its getting pretty silly in terms of 6 weeks passing since the
> > vote first opened for this tiny release, and it having already been
> > published elsewhere, I tweaked the website PR as I suggested some time
> > back and fixed some handling in the generated news items spotted in
> > checking it over, and have pushed those changes...it is now live on
> > the site and you can proceed to announce it.
> >
> > I dont know of anyone actively using the site on Windows, so its not
> > too surprising it doesnt work. It seems Jekyll itself isnt 'officially
> > supported' but can be made to run on Windows,
> > https://jekyllrb.com/docs/installation/windows/. It is of course
> > fairly easy to run a Linux guest on a Windows host in one various ways
> > these days, and so is what I would do.
> >
> > On Mon, 6 Jun 2022 at 13:59, Havret <h4...@gmail.com> wrote:
> > >
> > > Yeah, I still need to verify my PR locally, but the website is broken on
> > > windows. I will deal with it over the weekend.
> > >
> > > On Mon, Jun 6, 2022 at 12:15 PM Robbie Gemmell <robbie.gemmell@gmail.com
> > >
> > > wrote:
> > >
> > > > Website still needs to be updated and the release announced..
> > > >
> > > > On Tue, 24 May 2022 at 22:16, Havret <ha...@apache.org> wrote:
> > > > >
> > > > > Results of the activemq-nms-api 1.8.1-rc2 release vote.
> > > > >
> > > > > The vote passes with 6 Binding Votes
> > > > >
> > > > > Binding Votes:
> > > > > Michael André Pearce
> > > > > Clebert Suconic
> > > > > Jean-Baptiste Onofré
> > > > > Robbie Gemmell
> > > > > Jeff Genender
> > > > > Krzysztof Porebski
> > > > >
> > > > > Thank you for all the contributions and everyone's time reviewing the
> > > > > release candidate and voting.
> > > > >
> > > > > I will proceed with publishing the release now.
> > > > >
> > > > > Krzysztof
> > > > >
> > > > > On Tue, May 24, 2022 at 11:12 PM Havret <ha...@apache.org> wrote:
> > > > >
> > > > > > I'm adding my official +1 (binding),
> > > > > >
> > > > > > Krzysztof
> > > > > >
> > > > > > On Mon, May 23, 2022 at 6:32 PM Jeff Genender <
> > jgenender@apache.org>
> > > > > > wrote:
> > > > > >
> > > > > >> +1
> > > > > >>
> > > > > >> Jeff
> > > > > >>
> > > > > >>
> > > > > >> > On May 23, 2022, at 3:06 AM, Michael André Pearce <
> > > > > >> michael.andre.pearce@me.com.INVALID> wrote:
> > > > > >> >
> > > > > >> >
> > > > > >> > +1 (binding)
> > > > > >> >
> > > > > >> > Checked the notice and other files for correct year
> > > > > >> > Checked this API bundle with OpenWire main branch bumping its
> > > > version
> > > > > >> and seems to compile
> > > > > >> >
> > > > > >> >
> > > > > >> >
> > > > > >> >
> > > > > >> >> On 9 May 2022, at 21:35, Havret <ha...@apache.org> wrote:
> > > > > >> >>
> > > > > >> >>
> > > > > >> >> Hi all,
> > > > > >> >>
> > > > > >> >> I have put together a release of activemq-nms-api, please
> > check it
> > > > > >> >> and vote accordingly.
> > > > > >> >>
> > > > > >> >> This release contains a single bugfix[1] by Iuliia Fatkullina!
> > > > Thank
> > > > > >> you!
> > > > > >> >>
> > > > > >> >> Besides that I cherry-picked notice and license updates from
> > the
> > > > master
> > > > > >> >> branch[2].
> > > > > >> >>
> > > > > >> >> The files can be grabbed from:
> > > > > >> >>
> > > > > >>
> > > >
> > https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-api/1.8.1-rc2/
> > > > > >> <
> > > > > >>
> > > >
> > https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-api/1.8.1-rc2/
> > > > > >> >
> > > > > >> >>
> > > > > >> >> Regards,
> > > > > >> >> Krzysztof
> > > > > >> >>
> > > > > >> >> [1]: https://issues.apache.org/jira/browse/AMQNET-745 <
> > > > > >> https://issues.apache.org/jira/browse/AMQNET-745>
> > > > > >> >> [2]:
> > > > > >> >>
> > > > > >>
> > > >
> > https://github.com/apache/activemq-nms-api/commit/b837a87307aaca798b7ef6c2436d4d25b3f65c72
> > > > > >> <
> > > > > >>
> > > >
> > https://github.com/apache/activemq-nms-api/commit/b837a87307aaca798b7ef6c2436d4d25b3f65c72
> > > > > >> >
> > > > > >> >
> > > > > >> >
> > > > > >>
> > > > > >>
> > > >
> >
Re: [VOTE] Release activemq-nms-api 1.8.1-rc2
Posted by Havret <h4...@gmail.com>.
Sorry Robbie, I missed your email. I've already announced the release.
The problem I'm having with the activemq website on windows is that I
cannot even clone the repository. Every time I try to fetch it, I'm
getting the following error:
error: invalid path
'src/components/artemis/documentation/1.5.0/gitbook/fonts/fontawesome/fontawesome-webfont.eot?'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'
It works fine on MacOS though.
Thanks,
Krzysztof
On Mon, Jun 6, 2022 at 4:50 PM Robbie Gemmell <ro...@gmail.com>
wrote:
> Since its getting pretty silly in terms of 6 weeks passing since the
> vote first opened for this tiny release, and it having already been
> published elsewhere, I tweaked the website PR as I suggested some time
> back and fixed some handling in the generated news items spotted in
> checking it over, and have pushed those changes...it is now live on
> the site and you can proceed to announce it.
>
> I dont know of anyone actively using the site on Windows, so its not
> too surprising it doesnt work. It seems Jekyll itself isnt 'officially
> supported' but can be made to run on Windows,
> https://jekyllrb.com/docs/installation/windows/. It is of course
> fairly easy to run a Linux guest on a Windows host in one various ways
> these days, and so is what I would do.
>
> On Mon, 6 Jun 2022 at 13:59, Havret <h4...@gmail.com> wrote:
> >
> > Yeah, I still need to verify my PR locally, but the website is broken on
> > windows. I will deal with it over the weekend.
> >
> > On Mon, Jun 6, 2022 at 12:15 PM Robbie Gemmell <robbie.gemmell@gmail.com
> >
> > wrote:
> >
> > > Website still needs to be updated and the release announced..
> > >
> > > On Tue, 24 May 2022 at 22:16, Havret <ha...@apache.org> wrote:
> > > >
> > > > Results of the activemq-nms-api 1.8.1-rc2 release vote.
> > > >
> > > > The vote passes with 6 Binding Votes
> > > >
> > > > Binding Votes:
> > > > Michael André Pearce
> > > > Clebert Suconic
> > > > Jean-Baptiste Onofré
> > > > Robbie Gemmell
> > > > Jeff Genender
> > > > Krzysztof Porebski
> > > >
> > > > Thank you for all the contributions and everyone's time reviewing the
> > > > release candidate and voting.
> > > >
> > > > I will proceed with publishing the release now.
> > > >
> > > > Krzysztof
> > > >
> > > > On Tue, May 24, 2022 at 11:12 PM Havret <ha...@apache.org> wrote:
> > > >
> > > > > I'm adding my official +1 (binding),
> > > > >
> > > > > Krzysztof
> > > > >
> > > > > On Mon, May 23, 2022 at 6:32 PM Jeff Genender <
> jgenender@apache.org>
> > > > > wrote:
> > > > >
> > > > >> +1
> > > > >>
> > > > >> Jeff
> > > > >>
> > > > >>
> > > > >> > On May 23, 2022, at 3:06 AM, Michael André Pearce <
> > > > >> michael.andre.pearce@me.com.INVALID> wrote:
> > > > >> >
> > > > >> >
> > > > >> > +1 (binding)
> > > > >> >
> > > > >> > Checked the notice and other files for correct year
> > > > >> > Checked this API bundle with OpenWire main branch bumping its
> > > version
> > > > >> and seems to compile
> > > > >> >
> > > > >> >
> > > > >> >
> > > > >> >
> > > > >> >> On 9 May 2022, at 21:35, Havret <ha...@apache.org> wrote:
> > > > >> >>
> > > > >> >>
> > > > >> >> Hi all,
> > > > >> >>
> > > > >> >> I have put together a release of activemq-nms-api, please
> check it
> > > > >> >> and vote accordingly.
> > > > >> >>
> > > > >> >> This release contains a single bugfix[1] by Iuliia Fatkullina!
> > > Thank
> > > > >> you!
> > > > >> >>
> > > > >> >> Besides that I cherry-picked notice and license updates from
> the
> > > master
> > > > >> >> branch[2].
> > > > >> >>
> > > > >> >> The files can be grabbed from:
> > > > >> >>
> > > > >>
> > >
> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-api/1.8.1-rc2/
> > > > >> <
> > > > >>
> > >
> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-api/1.8.1-rc2/
> > > > >> >
> > > > >> >>
> > > > >> >> Regards,
> > > > >> >> Krzysztof
> > > > >> >>
> > > > >> >> [1]: https://issues.apache.org/jira/browse/AMQNET-745 <
> > > > >> https://issues.apache.org/jira/browse/AMQNET-745>
> > > > >> >> [2]:
> > > > >> >>
> > > > >>
> > >
> https://github.com/apache/activemq-nms-api/commit/b837a87307aaca798b7ef6c2436d4d25b3f65c72
> > > > >> <
> > > > >>
> > >
> https://github.com/apache/activemq-nms-api/commit/b837a87307aaca798b7ef6c2436d4d25b3f65c72
> > > > >> >
> > > > >> >
> > > > >> >
> > > > >>
> > > > >>
> > >
>
Re: [VOTE] Release activemq-nms-api 1.8.1-rc2
Posted by Robbie Gemmell <ro...@gmail.com>.
Since its getting pretty silly in terms of 6 weeks passing since the
vote first opened for this tiny release, and it having already been
published elsewhere, I tweaked the website PR as I suggested some time
back and fixed some handling in the generated news items spotted in
checking it over, and have pushed those changes...it is now live on
the site and you can proceed to announce it.
I dont know of anyone actively using the site on Windows, so its not
too surprising it doesnt work. It seems Jekyll itself isnt 'officially
supported' but can be made to run on Windows,
https://jekyllrb.com/docs/installation/windows/. It is of course
fairly easy to run a Linux guest on a Windows host in one various ways
these days, and so is what I would do.
On Mon, 6 Jun 2022 at 13:59, Havret <h4...@gmail.com> wrote:
>
> Yeah, I still need to verify my PR locally, but the website is broken on
> windows. I will deal with it over the weekend.
>
> On Mon, Jun 6, 2022 at 12:15 PM Robbie Gemmell <ro...@gmail.com>
> wrote:
>
> > Website still needs to be updated and the release announced..
> >
> > On Tue, 24 May 2022 at 22:16, Havret <ha...@apache.org> wrote:
> > >
> > > Results of the activemq-nms-api 1.8.1-rc2 release vote.
> > >
> > > The vote passes with 6 Binding Votes
> > >
> > > Binding Votes:
> > > Michael André Pearce
> > > Clebert Suconic
> > > Jean-Baptiste Onofré
> > > Robbie Gemmell
> > > Jeff Genender
> > > Krzysztof Porebski
> > >
> > > Thank you for all the contributions and everyone's time reviewing the
> > > release candidate and voting.
> > >
> > > I will proceed with publishing the release now.
> > >
> > > Krzysztof
> > >
> > > On Tue, May 24, 2022 at 11:12 PM Havret <ha...@apache.org> wrote:
> > >
> > > > I'm adding my official +1 (binding),
> > > >
> > > > Krzysztof
> > > >
> > > > On Mon, May 23, 2022 at 6:32 PM Jeff Genender <jg...@apache.org>
> > > > wrote:
> > > >
> > > >> +1
> > > >>
> > > >> Jeff
> > > >>
> > > >>
> > > >> > On May 23, 2022, at 3:06 AM, Michael André Pearce <
> > > >> michael.andre.pearce@me.com.INVALID> wrote:
> > > >> >
> > > >> >
> > > >> > +1 (binding)
> > > >> >
> > > >> > Checked the notice and other files for correct year
> > > >> > Checked this API bundle with OpenWire main branch bumping its
> > version
> > > >> and seems to compile
> > > >> >
> > > >> >
> > > >> >
> > > >> >
> > > >> >> On 9 May 2022, at 21:35, Havret <ha...@apache.org> wrote:
> > > >> >>
> > > >> >>
> > > >> >> Hi all,
> > > >> >>
> > > >> >> I have put together a release of activemq-nms-api, please check it
> > > >> >> and vote accordingly.
> > > >> >>
> > > >> >> This release contains a single bugfix[1] by Iuliia Fatkullina!
> > Thank
> > > >> you!
> > > >> >>
> > > >> >> Besides that I cherry-picked notice and license updates from the
> > master
> > > >> >> branch[2].
> > > >> >>
> > > >> >> The files can be grabbed from:
> > > >> >>
> > > >>
> > https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-api/1.8.1-rc2/
> > > >> <
> > > >>
> > https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-api/1.8.1-rc2/
> > > >> >
> > > >> >>
> > > >> >> Regards,
> > > >> >> Krzysztof
> > > >> >>
> > > >> >> [1]: https://issues.apache.org/jira/browse/AMQNET-745 <
> > > >> https://issues.apache.org/jira/browse/AMQNET-745>
> > > >> >> [2]:
> > > >> >>
> > > >>
> > https://github.com/apache/activemq-nms-api/commit/b837a87307aaca798b7ef6c2436d4d25b3f65c72
> > > >> <
> > > >>
> > https://github.com/apache/activemq-nms-api/commit/b837a87307aaca798b7ef6c2436d4d25b3f65c72
> > > >> >
> > > >> >
> > > >> >
> > > >>
> > > >>
> >
Re: [VOTE] Release activemq-nms-api 1.8.1-rc2
Posted by Havret <h4...@gmail.com>.
Yeah, I still need to verify my PR locally, but the website is broken on
windows. I will deal with it over the weekend.
On Mon, Jun 6, 2022 at 12:15 PM Robbie Gemmell <ro...@gmail.com>
wrote:
> Website still needs to be updated and the release announced..
>
> On Tue, 24 May 2022 at 22:16, Havret <ha...@apache.org> wrote:
> >
> > Results of the activemq-nms-api 1.8.1-rc2 release vote.
> >
> > The vote passes with 6 Binding Votes
> >
> > Binding Votes:
> > Michael André Pearce
> > Clebert Suconic
> > Jean-Baptiste Onofré
> > Robbie Gemmell
> > Jeff Genender
> > Krzysztof Porebski
> >
> > Thank you for all the contributions and everyone's time reviewing the
> > release candidate and voting.
> >
> > I will proceed with publishing the release now.
> >
> > Krzysztof
> >
> > On Tue, May 24, 2022 at 11:12 PM Havret <ha...@apache.org> wrote:
> >
> > > I'm adding my official +1 (binding),
> > >
> > > Krzysztof
> > >
> > > On Mon, May 23, 2022 at 6:32 PM Jeff Genender <jg...@apache.org>
> > > wrote:
> > >
> > >> +1
> > >>
> > >> Jeff
> > >>
> > >>
> > >> > On May 23, 2022, at 3:06 AM, Michael André Pearce <
> > >> michael.andre.pearce@me.com.INVALID> wrote:
> > >> >
> > >> >
> > >> > +1 (binding)
> > >> >
> > >> > Checked the notice and other files for correct year
> > >> > Checked this API bundle with OpenWire main branch bumping its
> version
> > >> and seems to compile
> > >> >
> > >> >
> > >> >
> > >> >
> > >> >> On 9 May 2022, at 21:35, Havret <ha...@apache.org> wrote:
> > >> >>
> > >> >>
> > >> >> Hi all,
> > >> >>
> > >> >> I have put together a release of activemq-nms-api, please check it
> > >> >> and vote accordingly.
> > >> >>
> > >> >> This release contains a single bugfix[1] by Iuliia Fatkullina!
> Thank
> > >> you!
> > >> >>
> > >> >> Besides that I cherry-picked notice and license updates from the
> master
> > >> >> branch[2].
> > >> >>
> > >> >> The files can be grabbed from:
> > >> >>
> > >>
> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-api/1.8.1-rc2/
> > >> <
> > >>
> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-api/1.8.1-rc2/
> > >> >
> > >> >>
> > >> >> Regards,
> > >> >> Krzysztof
> > >> >>
> > >> >> [1]: https://issues.apache.org/jira/browse/AMQNET-745 <
> > >> https://issues.apache.org/jira/browse/AMQNET-745>
> > >> >> [2]:
> > >> >>
> > >>
> https://github.com/apache/activemq-nms-api/commit/b837a87307aaca798b7ef6c2436d4d25b3f65c72
> > >> <
> > >>
> https://github.com/apache/activemq-nms-api/commit/b837a87307aaca798b7ef6c2436d4d25b3f65c72
> > >> >
> > >> >
> > >> >
> > >>
> > >>
>
Re: [VOTE] Release activemq-nms-api 1.8.1-rc2
Posted by Robbie Gemmell <ro...@gmail.com>.
Website still needs to be updated and the release announced..
On Tue, 24 May 2022 at 22:16, Havret <ha...@apache.org> wrote:
>
> Results of the activemq-nms-api 1.8.1-rc2 release vote.
>
> The vote passes with 6 Binding Votes
>
> Binding Votes:
> Michael André Pearce
> Clebert Suconic
> Jean-Baptiste Onofré
> Robbie Gemmell
> Jeff Genender
> Krzysztof Porebski
>
> Thank you for all the contributions and everyone's time reviewing the
> release candidate and voting.
>
> I will proceed with publishing the release now.
>
> Krzysztof
>
> On Tue, May 24, 2022 at 11:12 PM Havret <ha...@apache.org> wrote:
>
> > I'm adding my official +1 (binding),
> >
> > Krzysztof
> >
> > On Mon, May 23, 2022 at 6:32 PM Jeff Genender <jg...@apache.org>
> > wrote:
> >
> >> +1
> >>
> >> Jeff
> >>
> >>
> >> > On May 23, 2022, at 3:06 AM, Michael André Pearce <
> >> michael.andre.pearce@me.com.INVALID> wrote:
> >> >
> >> >
> >> > +1 (binding)
> >> >
> >> > Checked the notice and other files for correct year
> >> > Checked this API bundle with OpenWire main branch bumping its version
> >> and seems to compile
> >> >
> >> >
> >> >
> >> >
> >> >> On 9 May 2022, at 21:35, Havret <ha...@apache.org> wrote:
> >> >>
> >> >>
> >> >> Hi all,
> >> >>
> >> >> I have put together a release of activemq-nms-api, please check it
> >> >> and vote accordingly.
> >> >>
> >> >> This release contains a single bugfix[1] by Iuliia Fatkullina! Thank
> >> you!
> >> >>
> >> >> Besides that I cherry-picked notice and license updates from the master
> >> >> branch[2].
> >> >>
> >> >> The files can be grabbed from:
> >> >>
> >> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-api/1.8.1-rc2/
> >> <
> >> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-api/1.8.1-rc2/
> >> >
> >> >>
> >> >> Regards,
> >> >> Krzysztof
> >> >>
> >> >> [1]: https://issues.apache.org/jira/browse/AMQNET-745 <
> >> https://issues.apache.org/jira/browse/AMQNET-745>
> >> >> [2]:
> >> >>
> >> https://github.com/apache/activemq-nms-api/commit/b837a87307aaca798b7ef6c2436d4d25b3f65c72
> >> <
> >> https://github.com/apache/activemq-nms-api/commit/b837a87307aaca798b7ef6c2436d4d25b3f65c72
> >> >
> >> >
> >> >
> >>
> >>
Re: [VOTE] Release activemq-nms-api 1.8.1-rc2
Posted by Havret <ha...@apache.org>.
Results of the activemq-nms-api 1.8.1-rc2 release vote.
The vote passes with 6 Binding Votes
Binding Votes:
Michael André Pearce
Clebert Suconic
Jean-Baptiste Onofré
Robbie Gemmell
Jeff Genender
Krzysztof Porebski
Thank you for all the contributions and everyone's time reviewing the
release candidate and voting.
I will proceed with publishing the release now.
Krzysztof
On Tue, May 24, 2022 at 11:12 PM Havret <ha...@apache.org> wrote:
> I'm adding my official +1 (binding),
>
> Krzysztof
>
> On Mon, May 23, 2022 at 6:32 PM Jeff Genender <jg...@apache.org>
> wrote:
>
>> +1
>>
>> Jeff
>>
>>
>> > On May 23, 2022, at 3:06 AM, Michael André Pearce <
>> michael.andre.pearce@me.com.INVALID> wrote:
>> >
>> >
>> > +1 (binding)
>> >
>> > Checked the notice and other files for correct year
>> > Checked this API bundle with OpenWire main branch bumping its version
>> and seems to compile
>> >
>> >
>> >
>> >
>> >> On 9 May 2022, at 21:35, Havret <ha...@apache.org> wrote:
>> >>
>> >>
>> >> Hi all,
>> >>
>> >> I have put together a release of activemq-nms-api, please check it
>> >> and vote accordingly.
>> >>
>> >> This release contains a single bugfix[1] by Iuliia Fatkullina! Thank
>> you!
>> >>
>> >> Besides that I cherry-picked notice and license updates from the master
>> >> branch[2].
>> >>
>> >> The files can be grabbed from:
>> >>
>> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-api/1.8.1-rc2/
>> <
>> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-api/1.8.1-rc2/
>> >
>> >>
>> >> Regards,
>> >> Krzysztof
>> >>
>> >> [1]: https://issues.apache.org/jira/browse/AMQNET-745 <
>> https://issues.apache.org/jira/browse/AMQNET-745>
>> >> [2]:
>> >>
>> https://github.com/apache/activemq-nms-api/commit/b837a87307aaca798b7ef6c2436d4d25b3f65c72
>> <
>> https://github.com/apache/activemq-nms-api/commit/b837a87307aaca798b7ef6c2436d4d25b3f65c72
>> >
>> >
>> >
>>
>>
Re: [VOTE] Release activemq-nms-api 1.8.1-rc2
Posted by Havret <ha...@apache.org>.
I'm adding my official +1 (binding),
Krzysztof
On Mon, May 23, 2022 at 6:32 PM Jeff Genender <jg...@apache.org> wrote:
> +1
>
> Jeff
>
>
> > On May 23, 2022, at 3:06 AM, Michael André Pearce <
> michael.andre.pearce@me.com.INVALID> wrote:
> >
> >
> > +1 (binding)
> >
> > Checked the notice and other files for correct year
> > Checked this API bundle with OpenWire main branch bumping its version
> and seems to compile
> >
> >
> >
> >
> >> On 9 May 2022, at 21:35, Havret <ha...@apache.org> wrote:
> >>
> >>
> >> Hi all,
> >>
> >> I have put together a release of activemq-nms-api, please check it
> >> and vote accordingly.
> >>
> >> This release contains a single bugfix[1] by Iuliia Fatkullina! Thank
> you!
> >>
> >> Besides that I cherry-picked notice and license updates from the master
> >> branch[2].
> >>
> >> The files can be grabbed from:
> >>
> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-api/1.8.1-rc2/
> <
> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-api/1.8.1-rc2/
> >
> >>
> >> Regards,
> >> Krzysztof
> >>
> >> [1]: https://issues.apache.org/jira/browse/AMQNET-745 <
> https://issues.apache.org/jira/browse/AMQNET-745>
> >> [2]:
> >>
> https://github.com/apache/activemq-nms-api/commit/b837a87307aaca798b7ef6c2436d4d25b3f65c72
> <
> https://github.com/apache/activemq-nms-api/commit/b837a87307aaca798b7ef6c2436d4d25b3f65c72
> >
> >
> >
>
>
Re: [VOTE] Release activemq-nms-api 1.8.1-rc2
Posted by Jeff Genender <jg...@apache.org>.
+1
Jeff
> On May 23, 2022, at 3:06 AM, Michael André Pearce <mi...@me.com.INVALID> wrote:
>
>
> +1 (binding)
>
> Checked the notice and other files for correct year
> Checked this API bundle with OpenWire main branch bumping its version and seems to compile
>
>
>
>
>> On 9 May 2022, at 21:35, Havret <ha...@apache.org> wrote:
>>
>>
>> Hi all,
>>
>> I have put together a release of activemq-nms-api, please check it
>> and vote accordingly.
>>
>> This release contains a single bugfix[1] by Iuliia Fatkullina! Thank you!
>>
>> Besides that I cherry-picked notice and license updates from the master
>> branch[2].
>>
>> The files can be grabbed from:
>> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-api/1.8.1-rc2/ <https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-api/1.8.1-rc2/>
>>
>> Regards,
>> Krzysztof
>>
>> [1]: https://issues.apache.org/jira/browse/AMQNET-745 <https://issues.apache.org/jira/browse/AMQNET-745>
>> [2]:
>> https://github.com/apache/activemq-nms-api/commit/b837a87307aaca798b7ef6c2436d4d25b3f65c72 <https://github.com/apache/activemq-nms-api/commit/b837a87307aaca798b7ef6c2436d4d25b3f65c72>
>
>
Re: [VOTE] Release activemq-nms-api 1.8.1-rc2
Posted by Michael André Pearce <mi...@me.com.INVALID>.
+1 (binding)Checked the notice and other files for correct yearChecked this API bundle with OpenWire main branch bumping its version and seems to compileOn 9 May 2022, at 21:35, Havret <ha...@apache.org> wrote:Hi all,I have put together a release of activemq-nms-api, please check itand vote accordingly.This release contains a single bugfix[1] by Iuliia Fatkullina! Thank you!Besides that I cherry-picked notice and license updates from the masterbranch[2].The files can be grabbed from:https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-api/1.8.1-rc2/Regards,Krzysztof[1]: https://issues.apache.org/jira/browse/AMQNET-745[2]:https://github.com/apache/activemq-nms-api/commit/b837a87307aaca798b7ef6c2436d4d25b3f65c72
Re: [VOTE] Release activemq-nms-api 1.8.1-rc2
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
+1 (binding)
Regards
JB
On Mon, May 9, 2022 at 10:35 PM Havret <ha...@apache.org> wrote:
>
> Hi all,
>
> I have put together a release of activemq-nms-api, please check it
> and vote accordingly.
>
> This release contains a single bugfix[1] by Iuliia Fatkullina! Thank you!
>
> Besides that I cherry-picked notice and license updates from the master
> branch[2].
>
> The files can be grabbed from:
> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-api/1.8.1-rc2/
>
> Regards,
> Krzysztof
>
> [1]: https://issues.apache.org/jira/browse/AMQNET-745
> [2]:
> https://github.com/apache/activemq-nms-api/commit/b837a87307aaca798b7ef6c2436d4d25b3f65c72
Re: [VOTE] Release activemq-nms-api 1.8.1-rc2
Posted by Clebert Suconic <cl...@gmail.com>.
+1 (binding)
On Mon, May 23, 2022 at 6:09 AM Robbie Gemmell <ro...@gmail.com> wrote:
>
> + 1
>
> I verified the checksums and signatures, checked for LICENCE+NOTICE
> files, and ran a RAT check on the source archive.
>
> I haven't actually tried it out otherwise, only compared the diff [1].
> I noted some non-blocking niggles in the diff it might be good to fix
> for future:
> - Mismatched indentations from tabs vs spaces [2].
> - Incorrect link to license URL with old default branch name [3][4].
> It does redirect, so its not broken. Given that theres also a file
> based property given, which is what should be looked at, maybe even
> just remove the stale URL?
>
> (The RAT check flagged the .sln file, which as generated is ok not to
> have a header, but it might be simpler just to add it if possible.)
>
> [1] https://github.com/apache/activemq-nms-api/compare/1.8.0...1.8.1-rc2
> [2] https://github.com/apache/activemq-nms-api/compare/1.8.0...1.8.1-rc2#diff-c9e4f8d3720ab45fa81ee0d8249c8e19906480d689a0400d64279bad122bb131R328-R332
> [3] https://github.com/apache/activemq-nms-api/compare/1.8.0...1.8.1-rc2#diff-9483f9de89b2620833b851d472ad8c6cd861bc4d0e4fea7984d327b0d576cee4R42
> [4] https://github.com/apache/activemq-nms-api/compare/1.8.0...1.8.1-rc2#diff-f0dcebd9d7d9e1398afeca53c04987566f847cedb706505fcc60ed76d7f693f1R42
>
> On Mon, 9 May 2022 at 21:35, Havret <ha...@apache.org> wrote:
> >
> > Hi all,
> >
> > I have put together a release of activemq-nms-api, please check it
> > and vote accordingly.
> >
> > This release contains a single bugfix[1] by Iuliia Fatkullina! Thank you!
> >
> > Besides that I cherry-picked notice and license updates from the master
> > branch[2].
> >
> > The files can be grabbed from:
> > https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-api/1.8.1-rc2/
> >
> > Regards,
> > Krzysztof
> >
> > [1]: https://issues.apache.org/jira/browse/AMQNET-745
> > [2]:
> > https://github.com/apache/activemq-nms-api/commit/b837a87307aaca798b7ef6c2436d4d25b3f65c72
--
Clebert Suconic
Re: [VOTE] Release activemq-nms-api 1.8.1-rc2
Posted by Robbie Gemmell <ro...@gmail.com>.
+ 1
I verified the checksums and signatures, checked for LICENCE+NOTICE
files, and ran a RAT check on the source archive.
I haven't actually tried it out otherwise, only compared the diff [1].
I noted some non-blocking niggles in the diff it might be good to fix
for future:
- Mismatched indentations from tabs vs spaces [2].
- Incorrect link to license URL with old default branch name [3][4].
It does redirect, so its not broken. Given that theres also a file
based property given, which is what should be looked at, maybe even
just remove the stale URL?
(The RAT check flagged the .sln file, which as generated is ok not to
have a header, but it might be simpler just to add it if possible.)
[1] https://github.com/apache/activemq-nms-api/compare/1.8.0...1.8.1-rc2
[2] https://github.com/apache/activemq-nms-api/compare/1.8.0...1.8.1-rc2#diff-c9e4f8d3720ab45fa81ee0d8249c8e19906480d689a0400d64279bad122bb131R328-R332
[3] https://github.com/apache/activemq-nms-api/compare/1.8.0...1.8.1-rc2#diff-9483f9de89b2620833b851d472ad8c6cd861bc4d0e4fea7984d327b0d576cee4R42
[4] https://github.com/apache/activemq-nms-api/compare/1.8.0...1.8.1-rc2#diff-f0dcebd9d7d9e1398afeca53c04987566f847cedb706505fcc60ed76d7f693f1R42
On Mon, 9 May 2022 at 21:35, Havret <ha...@apache.org> wrote:
>
> Hi all,
>
> I have put together a release of activemq-nms-api, please check it
> and vote accordingly.
>
> This release contains a single bugfix[1] by Iuliia Fatkullina! Thank you!
>
> Besides that I cherry-picked notice and license updates from the master
> branch[2].
>
> The files can be grabbed from:
> https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-api/1.8.1-rc2/
>
> Regards,
> Krzysztof
>
> [1]: https://issues.apache.org/jira/browse/AMQNET-745
> [2]:
> https://github.com/apache/activemq-nms-api/commit/b837a87307aaca798b7ef6c2436d4d25b3f65c72