You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2019/04/08 19:10:25 UTC
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1080:
Update CONTRIBUTING.md
ctubbsii commented on a change in pull request #1080: Update CONTRIBUTING.md
URL: https://github.com/apache/accumulo/pull/1080#discussion_r273196972
##########
File path: CONTRIBUTING.md
##########
@@ -34,10 +34,5 @@ limitations under the License.
## Review
- We welcome reviews from anyone. Any committer can approve and merge the changes.
-- Reviewers will be looking for things like threading issues, performance implications, API design, etc.
-- Reviewers will likely ask questions to better understand your change.
-- Reviewers will make comments about changes to your patch:
- - MUST means that the change is required
- - SHOULD means that the change is suggested, further discussion on the subject may be required
- - COULD means that the change is optional
+- Reviewers will likely ask questions to better understand your change and follow these [guidelines](https://tools.ietf.org/html/rfc2119).
Review comment:
"and follow these guidelines" almost sounds instructional (imperative mood). It reads like "Reviewers will ... and (you should) follow these guidelines".
```suggestion
- Reviewers will likely have questions and comments. They may use terms such as those in [RFC2119](https://tools.ietf.org/html/rfc2119).
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services