[GitHub] [airflow] mobuchowski commented on a diff in pull request #31717: openlineage: add support for system tests, add support for example_bigquery_queries system test

["mobuchowski (via GitHub)" <gi...@apache.org>]

mobuchowski commented on code in PR #31717:
URL: https://github.com/apache/airflow/pull/31717#discussion_r1228010282


##########
tests/system/providers/google/cloud/bigquery/example_bigquery_queries.py:
##########
@@ -235,11 +236,21 @@
             trigger_rule=TriggerRule.ALL_DONE,
         )
 
+        openlineage_test = OpenlineageTestOperator(

Review Comment:
   I believe it's advantageous to have OL system tests as an addition to regular ones, because they are just an addition of one operator, and actively use rest of the dag.
   
   Those aren't only "OpenLineage system tests" in vacuum, but test OL integration of this particular provider.
   
   Having separate dags for system tests would result in fragmentation - we'd have to maintain the same dag, or at least subset of it, with just the addition of a single `OpenLineageTestOperator`. 
   
   However, I believe option to disable OpenLineage and make this special operator always pass is a very valid need, and will add such option.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org