You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/10/14 04:51:41 UTC

[GitHub] [apisix] rapiz1 opened a new pull request #5230: doc: fix the indent of README.md

rapiz1 opened a new pull request #5230:
URL: https://github.com/apache/apisix/pull/5230


   This PR should be a no-brainer.
   
   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   The original README is misaligned. This PR aligns the indent in Get Started properly.
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [x] Have you modified the corresponding document?
   * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] rapiz1 commented on pull request #5230: docs: fix the indent of README.md

Posted by GitBox <gi...@apache.org>.
rapiz1 commented on pull request #5230:
URL: https://github.com/apache/apisix/pull/5230#issuecomment-943135630


   I suppose the CI failures were irrelevant to this PR and may reflect some problem in the master branch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] leslie-tsang commented on pull request #5230: doc: fix the indent of README.md

Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on pull request #5230:
URL: https://github.com/apache/apisix/pull/5230#issuecomment-942961351


   Hello there, Would you mind checking if other documents have the same issue. like [`CN Readme`](https://github.com/apache/apisix/blob/2b239077432a8af1812c5f95fc5f01b748abaabf/docs/zh/latest/README.md?plain=1#L152-L156)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] rapiz1 commented on pull request #5230: doc: fix the indent of README.md

Posted by GitBox <gi...@apache.org>.
rapiz1 commented on pull request #5230:
URL: https://github.com/apache/apisix/pull/5230#issuecomment-943073369


   Corresponding changes were made.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander merged pull request #5230: docs: fix the indent of README.md

Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #5230:
URL: https://github.com/apache/apisix/pull/5230


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] leslie-tsang commented on pull request #5230: docs: fix the indent of README.md

Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on pull request #5230:
URL: https://github.com/apache/apisix/pull/5230#issuecomment-943145252


   > I suppose the CI failures were irrelevant to this PR and may reflect some problem in the master branch?
   
   Working on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org