You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "reschke (via GitHub)" <gi...@apache.org> on 2026/02/13 12:07:59 UTC
[PR] SLING-13113: xss: update of esapi dependency causes unresolved logging dependency in starter [sling-org-apache-sling-xss]
reschke opened a new pull request, #62:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/62
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13113: xss: update of esapi dependency causes unresolved logging dependency in starter [sling-org-apache-sling-xss]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on PR #62:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/62#issuecomment-3898240392
OK, so the attempt to"fix" (updating esapi to get rid if the log4j depeny in itself) was wrong in the first place?
FWIW, we'' have to checkt where the servlet version bump came from - maybe upadated sling parent???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13113: xss: update of esapi dependency causes unresolved logging dependency in starter [sling-org-apache-sling-xss]
Posted by "cziegeler (via GitHub)" <gi...@apache.org>.
cziegeler merged PR #62:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13113: xss: update of esapi dependency causes unresolved logging dependency in starter [sling-org-apache-sling-xss]
Posted by "cziegeler (via GitHub)" <gi...@apache.org>.
cziegeler commented on PR #62:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/62#issuecomment-3901968243
I just pushed the exclusion of the second commons.logging (as written by email). otherwise commons.logging is embedded in the jar - which is not what we want.
We still end up with commons.logging having no version range, but slf4j bundles only export 1.2 version anyway - we could hard-code this, but I dont see a real point
If we can downgrade the slf4j imports to 1.x and java servlet to 3.x that would be great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13113: xss: update of esapi dependency causes unresolved logging dependency in starter [sling-org-apache-sling-xss]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #62:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/62#issuecomment-3896861299
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-xss&pullRequest=62) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss&pullRequest=62&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss&pullRequest=62&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss&pullRequest=62&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss&pullRequest=62&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss&pullRequest=62&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-xss&pullRequest=62)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13113: xss: update of esapi dependency causes unresolved logging dependency in starter [sling-org-apache-sling-xss]
Posted by "rombert (via GitHub)" <gi...@apache.org>.
rombert commented on PR #62:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/62#issuecomment-3897852383
> > Needless to say, updating the bundle in products that are still on slf4j 1.x will not be possible.
>
> Yes. Is there a general Sling guideline for this?
Quoting https://cwiki.apache.org/confluence/display/SLING/Dependabot
> In Sling we have long had a policy of depending on the lowest possible version of the API, to ensure that our bundles are deployed in the widest possible range of environments.
In other words - if we don't need to rely in the newer API we should not. That goes for both javax.servlet and org.slf4j IMO.
The unversioned commons.logging import is also problematic. We can run into issues if whatever pulls it in actually wants 1.3 API but import an unversioned API which is actually 1.2 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13113: xss: update of esapi dependency causes unresolved logging dependency in starter [sling-org-apache-sling-xss]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on PR #62:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/62#issuecomment-3897600564
> Needless to say, updating the bundle in products that are still on slf4j 1.x will not be possible.
Yes. Is there a general Sling guideline for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13113: xss: update of esapi dependency causes unresolved logging dependency in starter [sling-org-apache-sling-xss]
Posted by "enapps-enorman (via GitHub)" <gi...@apache.org>.
enapps-enorman commented on PR #62:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/62#issuecomment-4148651594
Can we please wrap this one up so we have a functional latest release of the bundle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13113: xss: update of esapi dependency causes unresolved logging dependency in starter [sling-org-apache-sling-xss]
Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on PR #62:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/62#issuecomment-3904671671
But the new parent pom also leads to the servlet change - I assume that one is ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13113: xss: update of esapi dependency causes unresolved logging dependency in starter [sling-org-apache-sling-xss]
Posted by "cziegeler (via GitHub)" <gi...@apache.org>.
cziegeler commented on PR #62:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/62#issuecomment-3907178541
In general, the changes in the parent pom are ok, for XSS we should see that it can be used with older versions (of slf4j and servlet)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13113: xss: update of esapi dependency causes unresolved logging dependency in starter [sling-org-apache-sling-xss]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #62:
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/62#issuecomment-3901970520
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-xss&pullRequest=62) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss&pullRequest=62&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss&pullRequest=62&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss&pullRequest=62&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss&pullRequest=62&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss&pullRequest=62&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-xss&pullRequest=62)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org