You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/07/13 17:11:24 UTC

[GitHub] [couchdb] nickva commented on a diff in pull request #4104: Remove view compaction jobs recovery

nickva commented on code in PR #4104:
URL: https://github.com/apache/couchdb/pull/4104#discussion_r920320315


##########
src/smoosh/src/smoosh_channel.erl:
##########
@@ -28,6 +28,11 @@
     terminate/2
 ]).
 
+-define(VIEW_CHANNELS,
+    smoosh_utils:split(
+        config:get("smoosh", "view_channels", "upgrade_views,ratio_views,slack_views")
+    )
+).

Review Comment:
   Instead of a macro, I think it might look nicer as `smoosh_utils:is_view_channel(ChanName)` call. So we can keep the splitting and config in that module only



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org