You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "maheshrajus (via GitHub)" <gi...@apache.org> on 2025/04/01 16:17:26 UTC
[PR] TEZ-4618: JDK17: adding profile for jdk17 builds [tez]
maheshrajus opened a new pull request, #404:
URL: https://github.com/apache/tez/pull/404
adding profile for jdk17 builds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4618: JDK17: adding profile for jdk17 builds [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #404:
URL: https://github.com/apache/tez/pull/404#issuecomment-2770260445
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 13m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| -1 :x: | mvninstall | 7m 30s | root in master failed. |
| -1 :x: | compile | 0m 39s | root in master failed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04. |
| +1 :green_heart: | compile | 1m 30s | master passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +1 :green_heart: | javadoc | 1m 3s | master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | javadoc | 0m 46s | master passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 58s | the patch passed |
| +1 :green_heart: | compile | 1m 23s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | javac | 1m 23s | the patch passed |
| +1 :green_heart: | compile | 1m 13s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +1 :green_heart: | javac | 1m 13s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 45s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | javadoc | 0m 45s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 64m 23s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 27s | The patch does not generate ASF License warnings. |
| | | 97m 45s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-404/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/404 |
| JIRA Issue | TEZ-4618 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 8fb7e2d9d991 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 7c24f25ed |
| Default Java | Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| mvninstall | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-404/1/artifact/out/branch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-404/1/artifact/out/branch-compile-root-jdkUbuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04.txt |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-404/1/testReport/ |
| Max. process+thread count | 1556 (vs. ulimit of 5500) |
| modules | C: . U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-404/1/console |
| versions | git=2.34.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4618: JDK17: adding profile for jdk17 builds [tez]
Posted by "maheshrajus (via GitHub)" <gi...@apache.org>.
maheshrajus commented on PR #404:
URL: https://github.com/apache/tez/pull/404#issuecomment-2777635541
Raised PR.
https://github.com/apache/tez/pull/405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4618: JDK17: adding profile for jdk17 builds [tez]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on code in PR #404:
URL: https://github.com/apache/tez/pull/404#discussion_r2023579236
##########
pom.xml:
##########
@@ -1383,6 +1383,40 @@
</dependency>
</dependencies>
</profile>
+ <profile>
+ <id>java17</id>
+ <activation>
+ <jdk>[17,)</jdk>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <configuration>
+ <argLine>--add-opens java.base/java.lang=ALL-UNNAMED</argLine>
Review Comment:
argLine should also contain the -**_Xmx1024m -XX:+HeapDumpOnOutOfMemoryError_**, otherwise it will get overwritten. This can be confirmend by running test in debug mode. Rest of the configuration, evn and sytem properties are carried forward to java17 profile from the initial maven surefire plugin
```
mvn test -Dtest="org.apache.tez.dag.history.recovery.TestRecoveryService#testRecoveryFlushOnSummaryEvent" -X | grep "argLine"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4618: JDK17: adding profile for jdk17 builds [tez]
Posted by "maheshrajus (via GitHub)" <gi...@apache.org>.
maheshrajus closed pull request #404: TEZ-4618: JDK17: adding profile for jdk17 builds
URL: https://github.com/apache/tez/pull/404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org