You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Dave Brosius <db...@mebigfatguy.com> on 2013/05/20 21:49:14 UTC
Review Request: when comparing scopes, compare scope ids by value,
not reference.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11246/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
code compares Long values with == which will work for Long cached values, but not others
switched to use .equals
Diffs
-----
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/AbstractScope.java c94db66
Diff: https://reviews.apache.org/r/11246/diff/
Testing
-------
Thanks,
Dave Brosius
Re: Review Request: when comparing scopes, compare scope ids by value,
not reference.
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11246/#review20825
-----------------------------------------------------------
Ship it!
49faa002e220311f10a5f99993fad66a22836dad
- Prasanna Santhanam
On May 20, 2013, 7:49 p.m., Dave Brosius wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11246/
> -----------------------------------------------------------
>
> (Updated May 20, 2013, 7:49 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> code compares Long values with == which will work for Long cached values, but not others
>
> switched to use .equals
>
>
> Diffs
> -----
>
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/AbstractScope.java c94db66
>
> Diff: https://reviews.apache.org/r/11246/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dave Brosius
>
>
Re: Review Request: when comparing scopes, compare scope ids by value,
not reference.
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11246/#review20824
-----------------------------------------------------------
Ship it!
Ship It!
- Nitin Mehta
On May 20, 2013, 7:49 p.m., Dave Brosius wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11246/
> -----------------------------------------------------------
>
> (Updated May 20, 2013, 7:49 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> code compares Long values with == which will work for Long cached values, but not others
>
> switched to use .equals
>
>
> Diffs
> -----
>
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/AbstractScope.java c94db66
>
> Diff: https://reviews.apache.org/r/11246/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dave Brosius
>
>