You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "kanha-gupta (via GitHub)" <gi...@apache.org> on 2023/02/14 23:10:27 UTC

[GitHub] [shardingsphere] kanha-gupta opened a new pull request, #24167: Add test case for YamlPluginsConfigurationSwapper

kanha-gupta opened a new pull request, #24167:
URL: https://github.com/apache/shardingsphere/pull/24167

   Fixes #23418 .
   
   Changes proposed in this pull request:
     
   Testcase for YamlPluginsConfigurationSwapper
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [✔️ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [✔️ ] I have self-reviewed the commit code.
   - [✔️ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [✔️ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [✔️ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] RaigorJiang merged pull request #24167: Add test case for YamlPluginsConfigurationSwapper

Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang merged PR #24167:
URL: https://github.com/apache/shardingsphere/pull/24167


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #24167: Add test case for YamlPluginsConfigurationSwapper

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24167:
URL: https://github.com/apache/shardingsphere/pull/24167#issuecomment-1430670796

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24167?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#24167](https://codecov.io/gh/apache/shardingsphere/pull/24167?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d149728) into [master](https://codecov.io/gh/apache/shardingsphere/commit/8f78ad66d692e3bc4fa9931dd4235447f93a00df?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f78ad6) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head d149728 differs from pull request most recent head 526fc12. Consider uploading reports for the commit 526fc12 to get more accurate results
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #24167   +/-   ##
   =========================================
     Coverage     50.13%   50.14%           
     Complexity     1579     1579           
   =========================================
     Files          3258     3258           
     Lines         53508    53508           
     Branches       9853     9853           
   =========================================
   + Hits          26827    26831    +4     
   + Misses        24322    24320    -2     
   + Partials       2359     2357    -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../yaml/swapper/YamlPluginsConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/24167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4vY29uZmlnL3lhbWwvc3dhcHBlci9ZYW1sUGx1Z2luc0NvbmZpZ3VyYXRpb25Td2FwcGVyLmphdmE=) | `100.00% <0.00%> (+33.33%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] RaigorJiang commented on pull request #24167: Add test case for YamlPluginsConfigurationSwapper

Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on PR #24167:
URL: https://github.com/apache/shardingsphere/pull/24167#issuecomment-1430673841

   @kanha-gupta Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org