[jira] [Commented] (AMQ-6034) The StompConnection class contains incorrect STOMP code

["Matt Pavlovich (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294680#comment-17294680 ] 

Matt Pavlovich commented on AMQ-6034:
-------------------------------------

This issue is being marked 'close-pending' due to its age and inactivity.

Please update if this is still an issue with 5.16.x or newer.

> The StompConnection class contains incorrect STOMP code
> -------------------------------------------------------
>
>                 Key: AMQ-6034
>                 URL: https://issues.apache.org/jira/browse/AMQ-6034
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: STOMP
>            Reporter: Lionel Cons
>            Priority: Major
>
> The org.apache.activemq.transport.stomp.StompConnection class contains  incorrect code related to STOMP frame handling.
> On the receiving side, receive() uses StompWireFormat which is correct. However, the class also contains receiveFrame() which is not correct.
> On the sending side, most related methods use the StompFrame.format() method which is not correct, StompWireFormat.marshal() should be used instead.
> So, StompWireFormat should be used in all the marshal/unmarshal operations and equivalent code should be removed from the related classes like StompConnection.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)